Increase test coverage for samsungtv component #14900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.device.send_key(command) | ||
| self.assertEqual(STATE_ON, self.device._state) | ||
| # verify that _remote.control() get called twice because of retry logic | ||
| _remote.assert_has_calls([ |
There was a problem hiding this comment.
We prefer to use assert statement and mock.call_args, to avoid a test passing despite error if assert_has_calls is misspelled.
There was a problem hiding this comment.
Good to know. I updated my PR with the suggested change.
c8c8eab to
2222e74
Compare
More test cases to cover retry logic added in 58a1c38
2222e74 to
87f6e05
Compare
MartinHjelmare
approved these changes
Jun 12, 2018
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
More test cases to cover retry logic added in 58a1c38
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
More test cases to cover retry logic added in PR #14587.
Checklist:
tox. Your PR cannot be merged unless tests pass