-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
Upgrade python-nest, add security_state sensor, nest.set_mode service set ETA as well #14901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Small comment on grammar.
description: Optional ETA window. Default is 1 minute. | ||
example: 0:5 | ||
trip_id: | ||
description: Optional the identity of a trip. Use same trip_id will update the estimation for a trip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional identity of a trip. Using the same trip_ID will update...
Can be merged when build passes. |
vol.Required(ATTR_HOME_MODE): vol.In([HOME_MODE_AWAY, HOME_MODE_HOME]), | ||
vol.Optional(ATTR_STRUCTURE): vol.All(cv.ensure_list, cv.string), | ||
vol.Optional(ATTR_TRIP_ID): cv.string, | ||
vol.Optional(ATTR_ETA): cv.time_period_str, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a time_period
instead of time_period_str
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix in #14938
Description:
Upgrade python-nest to 4.0.2, which allows follows changes possible.
Add security_state sensor
security_state
is provided by Nest Security API, please note, it is NOT API for Nest Secure Alarm System.You can use this sensor to convert your HA + Nest Cam to a cheap security system
Set ETA
nest.set_mode
service extended to allow set ETA when you setaway
mode.See here for more information
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5518
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirements_all.txt
by runningscript/gen_requirements_all.py
.