Fix Skybell binary sensor state update #14927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 11, 2018
| @@ -80,3 +80,5 @@ def update(self): | |||
|
|
|||
| if self._sensor_type == 'chime_level': | |||
| self._state = self._device.outdoor_chime_level | |||
| else | |||
| self._state = STATE_UNKNOWN | |||
| @@ -80,3 +80,5 @@ def update(self): | |||
|
|
|||
| if self._sensor_type == 'chime_level': | |||
| self._state = self._device.outdoor_chime_level | |||
| else | |||
72746f0 to
ed1277c
Compare
|
Using |
|
@amelchio Thanks, I didn't know that. I'll remove that commit. |
ed1277c to
cb0a3d3
Compare
balloob
approved these changes
Jun 15, 2018
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
binary_sensor.skybellplatform can fail to update its state when the event list returned by the Skybell API does not have entries for the monitored conditions. This is due to an bug that makes the event listNonerather than an empty dictionary.Both
binary_sensor.skybellandsensor.skybellcan also returnNoneinstead ofSTATE_UNKNOWNas their state, this is also fixed.Related issue (if applicable): fixes #14871
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass