Add unique_id for mqtt binary sensor #14929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
| 'unique_id': 'TOTALLY_UNIQUE' | ||
| }] | ||
| }) | ||
|
|
There was a problem hiding this comment.
We should test the unique id functionality by firing an mqtt message. See sensor mqtt tests.
There was a problem hiding this comment.
Apologies, when splitting I missed a few lines and unfortunately test passed without those. I'll be more attentive on next split.
2 tasks
|
@MartinHjelmare Fixed test and added documentation as well. |
awarecan
pushed a commit
to awarecan/home-assistant
that referenced
this pull request
Jun 13, 2018
* Added unique_id for mqtt binary sensor * Added missing mqtt message fire in test
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Added unique_id for mqtt binary sensor * Added missing mqtt message fire in test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added unique_id for mqtt binary sensor. Use case for zigbee2mqtt to allow renaming just like xiaomi_aqara.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5538
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices: