Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add scan_interval to RainMachine #14945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Jun 12, 2018

Description:

This PR adds makes RainMachine compatible with the scan_machine configuration key.

Related issue (if applicable): N/A

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5535

Example entry for configuration.yaml (if applicable):

rainmachine:
  ip_address: 192.168.2.16
  password: password_123

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:
- [ ] New dependencies have been added to the REQUIREMENTS variable (example).
- [ ] New dependencies are only imported inside functions that use them (example).
- [ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
- [ ] New files were added to .coveragerc.

@pvizeli pvizeli merged commit 176ef41 into home-assistant:dev Jun 13, 2018
@ghost ghost removed the in progress label Jun 13, 2018
@bachya bachya deleted the rainmachine-scan-interval branch June 13, 2018 17:14
@balloob balloob mentioned this pull request Jun 22, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants