Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove inline pylint disables for messages disabled in pylintrc #14978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Remove inline pylint disables for messages disabled in pylintrc #14978

merged 1 commit into from
Jun 15, 2018

Conversation

scop
Copy link
Member

@scop scop commented Jun 15, 2018

Description:

There are a lot of unnecessary inline pylint disable=... in the code. This cleans the low-hanging fruits -- messages that are already disabled in pylintrc.

Checklist:

  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@scop scop requested review from Danielhiversen, rytilahti, syssi and a team as code owners June 15, 2018 21:28
@ghost ghost added the in progress label Jun 15, 2018
Copy link
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@pvizeli pvizeli merged commit 4bd7a7e into home-assistant:dev Jun 15, 2018
@ghost ghost removed the in progress label Jun 15, 2018
@scop scop deleted the pylint-cleanup branch June 16, 2018 06:25
@balloob balloob mentioned this pull request Jun 22, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants