Fix extended package support #14980
Merged
Fix extended package support #14980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 15, 2018
homeassistant/config.py
Outdated
| package=comp_conf) | ||
| if error: | ||
| _log_pkg_error(pack_name, comp_name, config, | ||
| "has duplicate key '{}'".format(error)) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
houndci-bot
reviewed
Jun 15, 2018
homeassistant/config.py
Outdated
| package=comp_conf) | ||
| if error: | ||
| _log_pkg_error(pack_name, comp_name, config, | ||
| "has duplicate key '{}'".format(error)) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
balloob
approved these changes
Jun 16, 2018
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Fix package recurive merge bug * Fixed extended package support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is my attempt at fixing the extended package support I introduced with #14611. Some users reported that it didn't work with all components which I can confirm.
I tested the code, but due to the complexity their might still be bugs left. Hence this should not be a hot fix.
Related issue (if applicable): fixes #14906
Related issue (if applicable): fixes #14920
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass