Do not mount deps folder when running in virtual env #14993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 16, 2018
homeassistant/config.py
Outdated
| @@ -25,7 +25,7 @@ | |||
| from homeassistant.loader import get_component, get_platform | |||
| from homeassistant.util.yaml import load_yaml, SECRET_YAML | |||
| import homeassistant.helpers.config_validation as cv | |||
| from homeassistant.util import dt as date_util, location as loc_util | |||
| from homeassistant.util import dt as date_util, location as loc_util, package | |||
There was a problem hiding this comment.
'homeassistant.util.package' imported but unused
pvizeli
approved these changes
Jun 16, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When running in a virtual environment, do not add the dependencies inside the config folder to the module search path.
Related issue (if applicable): fixes #14991
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: