Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sweenu
Copy link

@sweenu sweenu commented Nov 1, 2025

Breaking change

This PR totally reimplements the bbox integration, but I don't think we can call it a breaking change, as that integration is plainly broken in the current state (the underlying library does not support the current versions of python supported by HA and throws errors as soon as the integration is enabled).

Proposed change

I wrote a new, async, up to standards api wrapper for bbox: https://github.com/sweenu/aiobbox
And inspired myself from the platinum vodafone_station integration to bring the bbox one up to standards as well.

I did not add any new features, but it creates a good foundation to do so in the future.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@sweenu sweenu requested a review from a team as a code owner November 1, 2025 23:50
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sweenu

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot added cla-needed code-quality config-flow This integration migrates to the UI by adding a config flow has-tests integration: bbox labels Nov 1, 2025
@home-assistant
Copy link

home-assistant bot commented Nov 1, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sweenu

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@sweenu sweenu marked this pull request as ready for review November 2, 2025 19:50
@home-assistant home-assistant bot dismissed stale reviews from themself November 2, 2025 19:50

Stale

@sweenu sweenu changed the title bbox: update integration to current standards bbox: Legacy -> Platinum Nov 2, 2025
@sweenu sweenu marked this pull request as draft November 2, 2025 20:34
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold up a moment, I genuinely love this change, but we should go step by step, not all at once. Rough path forward:

  1. update the dependency
  2. Add the config flow (these 2 can be changed, depends on what you need)
  3. Add a coordinator
  4. Add the quality scale yaml somewhere in between
  5. Do every other rule about 1 PR at a time, sometimes they're easy to group as they're related

@sweenu sweenu mentioned this pull request Nov 3, 2025
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate bbox from DeviceScanner to ScannerEntity

2 participants