-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
bbox: Legacy -> Platinum #155651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
bbox: Legacy -> Platinum #155651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold up a moment, I genuinely love this change, but we should go step by step, not all at once. Rough path forward:
- update the dependency
- Add the config flow (these 2 can be changed, depends on what you need)
- Add a coordinator
- Add the quality scale yaml somewhere in between
- Do every other rule about 1 PR at a time, sometimes they're easy to group as they're related
Breaking change
This PR totally reimplements the bbox integration, but I don't think we can call it a breaking change, as that integration is plainly broken in the current state (the underlying library does not support the current versions of python supported by HA and throws errors as soon as the integration is enabled).
Proposed change
I wrote a new, async, up to standards api wrapper for bbox: https://github.com/sweenu/aiobbox
And inspired myself from the platinum vodafone_station integration to bring the bbox one up to standards as well.
I did not add any new features, but it creates a good foundation to do so in the future.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: