Squeezebox: provide player sensor for next alarm timestamp #155788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Martin Hjelmare <[email protected]>
|
Hey there @rajlaud, @pssc, @peteS-UK, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR adds player-level alarm sensors to the Squeezebox integration, complementing the existing server-level sensors. The new functionality includes three binary sensors for alarm states (active, snoozed, upcoming) and one timestamp sensor for the next scheduled alarm time.
Key changes:
- Added player-based alarm sensors (binary sensors for alarm states and timestamp sensor for next alarm)
- Refactored test setup to use platform-specific fixtures reducing code duplication
- Introduced new sensor entity classes that follow the existing SqueezeboxEntity pattern
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/squeezebox/sensor.py | Added player alarm timestamp sensor entity class and setup logic |
| homeassistant/components/squeezebox/binary_sensor.py | Added player alarm binary sensor entities for active, snoozed, and upcoming states |
| homeassistant/components/squeezebox/const.py | Added constants for new player alarm sensor keys |
| homeassistant/components/squeezebox/strings.json | Added translation keys for the new alarm sensor entities |
| tests/components/squeezebox/test_sensor.py | Added test coverage for player alarm sensor and refactored test structure |
| tests/components/squeezebox/test_binary_sensor.py | Added comprehensive tests for player alarm binary sensors |
| tests/components/squeezebox/test_switch.py | Fixed incorrect docstring describing media_player instead of switch |
| tests/components/squeezebox/conftest.py | Added alarm-related mock attributes to test player fixture |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR provides a player sensor with the time stamp of the next scheduled alarm for this player. It is a follow-up to #154491 which provides binary sensors for player alarms.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: