Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Matter DoorPositionSensor feature attributes #155809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Matter DoorPositionSensor feature attributes #155809

wants to merge 2 commits into from

Conversation

@lboue
Copy link
Contributor

@lboue lboue commented Nov 4, 2025 •
edited
Loading

Proposed change

Adds two new diagnostic sensors to the Matter integration for tracking door lock events:

  • door opened events
  • door closed events

These sensors use the DoorLock cluster's DoorOpenEvents and DoorClosedEvents attributes and are only available when the DoorPositionSensor feature is present.

  • Adds two new sensor entity descriptions for door open/closed event counters
  • Provides translations and icons for the new sensors
  • Both sensors are marked as diagnostic entities with TOTAL state class

Attributes found in the SwitchBot Lock Pro device

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 4, 2025

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@lboue lboue marked this pull request as ready for review November 4, 2025 21:35
Copilot AI review requested due to automatic review settings November 4, 2025 21:35
@lboue lboue requested a review from a team as a code owner November 4, 2025 21:35
Copilot AI reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds two new diagnostic sensors to the Matter integration for tracking door lock events: door opened events and door closed events. These sensors use the DoorLock cluster's DoorOpenEvents and DoorClosedEvents attributes and are only available when the kDoorPositionSensor feature is present.

  • Adds two new sensor entity descriptions for door open/closed event counters
  • Provides translations and icons for the new sensors
  • Both sensors are marked as diagnostic entities with TOTAL state class

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
homeassistant/components/matter/sensor.py Adds two MatterDiscoverySchema entries for door opened/closed event sensors
homeassistant/components/matter/strings.json Adds translation strings for the door event sensor names
homeassistant/components/matter/icons.json Adds Material Design icons for the door event sensors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

by-code-owner cla-signed integration: matter new-feature Quality Scale: No score

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lboue