Support serving ES6 JS to clients #596

andrey-git · 2017-11-08T22:10:05Z

Add an option to serve ES6 JS to clients
Backend PR: home-assistant/core#10474

In addition to hass_frontend package with all the frontend content, generate hass_frontend_es6 that contains untranspiled* files.

(Not really untranspiled, as react JS is still transpiled to regular JS, and babel es2016 preset is used)

@balloob I didn't check that hassio-panel produces valid result.

houndci-bot

Some files could not be reviewed due to errors:

Oops! Something went wrong! :(
ESLint: 4.9.0.
ESLint couldn't find the plugin "eslint-plugin-html". This can happen for a couple different reasons:
1. If ESLint is installed globally, then make sure eslint-plugin-html is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
    npm i eslint-plugin-html@latest --save-dev
If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.

balloob · 2017-11-09T06:32:19Z

rollup.config-es6.js

+    babelrc: false,
+    presets: [
+      [
+        'es2016',


I wonder if we can just remove any preset completely?

If we want to use a preset, we should use browser-env.

Using babel-preset-env which takes in a browserlist query.

We can support latest 2 versions of Chrome, Firefox and Safari?

http://browserl.ist/?q=last+2+firefox+versions%2C+last+2+chrome+versions%2C+last+2+safari+versions

https://github.com/babel/babel/tree/master/experimental/babel-preset-env

Removed completely

balloob · 2017-11-09T06:33:07Z

rollup.config-es6.js

+    ],
+    plugins: [
+      'external-helpers',
+      'transform-object-rest-spread',


This one too is in the modern browsers.

Browsers recognize it, but rollup doesn't.

balloob · 2017-11-09T06:33:19Z

rollup.config-es6.js

+      ]
+    ],
+    plugins: [
+      'external-helpers',


If we don't transpile, we don't need this.

We need this if we do browser-env.

Without it a warning is issued. Lets keep it.

balloob · 2017-11-09T06:33:31Z

rollup.config-es6.js

+      'external-helpers',
+      'transform-object-rest-spread',
+      [
+        'transform-react-jsx',


This is the only thing we need :-)

balloob · 2017-11-09T06:35:03Z

gulp/tasks/default.js

@@ -4,6 +4,7 @@ const runSequence = require('run-sequence');
 gulp.task('default', () => {
  return runSequence.use(gulp)(
    'clean',
-    'build'
+    'build',
+    'build_es6'


I know it's kind of too late now, but I think "modern" would have been a better suffix that would stand time as I can see us changing what we transpile.

Maybe change to es5 and un-suffixed?

Oh I like that more. ES5 is a fixed goal.

balloob · 2017-11-09T06:48:52Z

gulp/common/transform.js

      sourceType: 'script',
      presets: [
-        ['es2015', { modules: false }]
+        es6 ? ['es2016'] : ['es2015', { modules: false }]


Should this be browser-env too?

Removed completely

balloob · 2017-11-09T06:51:36Z

gulp/tasks/gen-service-worker.js

+const fs = require('fs');
+const path = require('path');
+const swPrecache = require('sw-precache');
+// var uglifyJS = require('uglify-js');


stale comment.

houndci-bot

Some files could not be reviewed due to errors:

Oops! Something went wrong! :(
ESLint: 4.9.0.
ESLint couldn't find the plugin "eslint-plugin-html". This can happen for a couple different reasons:
1. If ESLint is installed globally, then make sure eslint-plugin-html is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
    npm i eslint-plugin-html@latest --save-dev
If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.

houndci-bot

Some files could not be reviewed due to errors:

Oops! Something went wrong! :(
ESLint: 4.9.0.
ESLint couldn't find the plugin "eslint-plugin-html". This can happen for a couple different reasons:
1. If ESLint is installed globally, then make sure eslint-plugin-html is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
    npm i eslint-plugin-html@latest --save-dev
If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.

houndci-bot

Some files could not be reviewed due to errors:

Oops! Something went wrong! :(
ESLint: 4.9.0.
ESLint couldn't find the plugin "eslint-plugin-html". This can happen for a couple different reasons:
1. If ESLint is installed globally, then make sure eslint-plugin-html is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
    npm i eslint-plugin-html@latest --save-dev
If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.

houndci-bot

Some files could not be reviewed due to errors:

Oops! Something went wrong! :(
ESLint: 4.9.0.
ESLint couldn't find the plugin "eslint-plugin-html". This can happen for a couple different reasons:
1. If ESLint is installed globally, then make sure eslint-plugin-html is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
    npm i eslint-plugin-html@latest --save-dev
If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.

houndci-bot

Some files could not be reviewed due to errors:

Oops! Something went wrong! :(
ESLint: 4.9.0.
ESLint couldn't find the plugin "eslint-plugin-html". This can happen for a couple different reasons:
1. If ESLint is installed globally, then make sure eslint-plugin-html is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
    npm i eslint-plugin-html@latest --save-dev
If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.

balloob · 2017-11-10T02:00:22Z

@pvizeli reminder that I need to fix the Hass.io build before the next release.

andrey-git · 2017-11-10T17:36:22Z

Ouch, now if someone syncs FE they will get a broken experience until BE is submitted too.

balloob · 2017-11-11T05:44:40Z

Yeah, sorry about that 😞 thanks for the quick fix!

* Support serving ES6 JS to clients * Make es6 default dir and es5 a special dir * Fix package building * Fix build_frontend script

Support serving ES6 JS to clients

267309f

homeassistant added the cla-signed label Nov 8, 2017

houndci-bot reviewed Nov 8, 2017

View reviewed changes

andrey-git mentioned this pull request Nov 8, 2017

Add an option to serve ES6 JS to clients home-assistant/core#10474

Merged

3 tasks

balloob reviewed Nov 9, 2017

View reviewed changes

rollup.config-es6.js

'external-helpers',

'transform-object-rest-spread',

[

'transform-react-jsx',

Copy link

Member

balloob Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only thing we need :-)

balloob reviewed Nov 9, 2017

View reviewed changes

Make es6 default dir and es5 a special dir

d94115d

houndci-bot reviewed Nov 9, 2017

View reviewed changes

Fix package building

d325866

houndci-bot reviewed Nov 9, 2017

View reviewed changes

Fix build_frontend script

2c23660

houndci-bot reviewed Nov 9, 2017

View reviewed changes

balloob approved these changes Nov 10, 2017

View reviewed changes

balloob merged commit 583abed into home-assistant:master Nov 10, 2017

andrey-git deleted the es6 branch November 11, 2017 22:06

github-actions bot locked and limited conversation to collaborators Jul 8, 2022

Support serving ES6 JS to clients #596

Support serving ES6 JS to clients #596

Uh oh!

Conversation

andrey-git commented Nov 8, 2017

Uh oh!

houndci-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

balloob Nov 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

houndci-bot left a comment

Choose a reason for hiding this comment

Uh oh!

houndci-bot left a comment

Choose a reason for hiding this comment

Uh oh!

houndci-bot left a comment

Choose a reason for hiding this comment

Uh oh!

houndci-bot left a comment

Choose a reason for hiding this comment

Uh oh!

houndci-bot left a comment

Choose a reason for hiding this comment

Uh oh!

balloob commented Nov 10, 2017

Uh oh!

andrey-git commented Nov 10, 2017

Uh oh!

balloob commented Nov 11, 2017

Uh oh!

Uh oh!

balloob Nov 9, 2017 •

edited

Loading