Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add frontend for system log #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2017
Merged

Conversation

postlund
Copy link
Contributor

@postlund postlund commented Nov 9, 2017

This is the frontend code for the system log I'm implementing. See pull request in the Home Assistant repo for more details.

@balloob
Copy link
Member

balloob commented Nov 13, 2017

Future idea: add a report button to push stacktraces to us.

@balloob
Copy link
Member

balloob commented Nov 13, 2017

I don't think that this should be a panel but instead be integrated into the info dev tool.

@postlund
Copy link
Contributor Author

Do you have any preferences on how you want it to look? Or should I just keep current layout and put it below the "line"?

@balloob
Copy link
Member

balloob commented Nov 15, 2017

I like that idea 👍

@postlund
Copy link
Contributor Author

So, I've updated the frontend now and it looks something like this:

screenshot

I decided to change so that the full log is not automatically loaded and so that the user has to press refresh manually. It's quite sluggish if the log is large and should hopehully be less needed now with the new system log.

@postlund
Copy link
Contributor Author

I have cleaned up a bit but an "issue" I have is that the paper-dialog is not scrollable (on desktop, works fine on my phone), so long output might not be possible to see. Been playing around with paper-dialog-scrollable but cannot get it to work. Any tips on what to do?

@balloob
Copy link
Member

balloob commented Nov 16, 2017

@@ -41,7 +46,6 @@

.error-log-intro {
margin-top: 16px;
border-top: 1px solid var(--light-primary-color);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're removing the border, remove the padding top and set margin to 24px.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, I hope I understood you correctly.

border-radius: 2px;
}

@media all and (max-width: 450px) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the max-width is 450px, change the padding off the content on the sides to 0 so the cards take the full width.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@postlund
Copy link
Contributor Author

I've tried to follow how it's done in more-info-dialog but I cannot really seem to get it working the way I want it to. The changes I've made are included in the latest commit. Current behavior for me is that it's horizontally scrollable but not vertically on my phone (I currently have no possibility of testing on desktop). So something is wrong but I don't know what.

@balloob
Copy link
Member

balloob commented Nov 17, 2017

Tested it locally and seems to work ok.

For future PR: after clear, we should clear the known issues in the browser.

@balloob
Copy link
Member

balloob commented Nov 17, 2017

Thanks 🌮 🐬

@balloob balloob merged commit c0df1e2 into home-assistant:master Nov 17, 2017
@postlund postlund deleted the system_log branch November 17, 2017 07:21
@postlund
Copy link
Contributor Author

🎉🎉🎉

I fixed so that it worked on desktop, but it’s still an issue on my phone. If I tap “Log details”, then I can scroll but it doesn’t work with the content for some reason. A PR that fixes automatic “clear” is in the making!

@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants