-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add frontend for system log #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Future idea: add a report button to push stacktraces to us. |
I don't think that this should be a panel but instead be integrated into the info dev tool. |
Do you have any preferences on how you want it to look? Or should I just keep current layout and put it below the "line"? |
I like that idea 👍 |
I have cleaned up a bit but an "issue" I have is that the |
@@ -41,7 +46,6 @@ | |||
|
|||
.error-log-intro { | |||
margin-top: 16px; | |||
border-top: 1px solid var(--light-primary-color); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're removing the border, remove the padding top and set margin to 24px.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed, I hope I understood you correctly.
border-radius: 2px; | ||
} | ||
|
||
@media all and (max-width: 450px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the max-width is 450px, change the padding off the content on the sides to 0 so the cards take the full width.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
I've tried to follow how it's done in |
Tested it locally and seems to work ok. For future PR: after clear, we should clear the known issues in the browser. |
Thanks 🌮 🐬 |
🎉🎉🎉 I fixed so that it worked on desktop, but it’s still an issue on my phone. If I tap “Log details”, then I can scroll but it doesn’t work with the content for some reason. A PR that fixes automatic “clear” is in the making! |
This is the frontend code for the system log I'm implementing. See pull request in the Home Assistant repo for more details.