Convert configurator to markdown #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
andrey-git
reviewed
Nov 19, 2017
src/util/ha-url-sync.html
Outdated
| // We keep track of where we opened moreInfo from so that we don't | ||
| // pop the state when we close the modal if the modal has navigated | ||
| // us away. | ||
| this.moreInfoOpenedFromPath = window.location.pathname; |
There was a problem hiding this comment.
Move this to before pushState? Could there be some callback on it that changes location?
There was a problem hiding this comment.
Updated it. Shouldn't happen right now but order doesn't matter, so why not.
andrey-git
approved these changes
Nov 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iron-resizewhen images in it are done loadingTreeWalker😎/config), instead of navigating the whole page, it uses pushState to navigate. This caused some issues with the url sync hack that we have that pops the state when we close a more info dialog. I fixed this by only popping state if the url is still the same as the url from which we pushed an extra state to the stack.Backend PR: home-assistant/core#10668