Thanks to visit codestin.com
Credit goes to github.com

Skip to content

pytradfri 5.5.1: Improved 3rd party bulb support #14887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 13, 2018
Merged

pytradfri 5.5.1: Improved 3rd party bulb support #14887

merged 9 commits into from
Jun 13, 2018

Conversation

Hate-Usernames
Copy link
Contributor

@Hate-Usernames Hate-Usernames commented Jun 9, 2018 •
edited
Loading

Description:

  • Improves support for 3rd party bulbs:
    • Supported features should now be accurately reported
    • Paired Philips hue bulbs support transitioning both colour and brightness simultaneously
  • Adds tests

Related issue (if applicable): fixes #14565, fixes #14525, fixes #14554

Example entry for configuration.yaml (if applicable):

tradfri:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Jun 9, 2018
@Hate-Usernames
Copy link
Contributor Author

WIP until 5.5 is released to PyPI

@Hate-Usernames Hate-Usernames force-pushed the tradfri-combine-commands branch from b587696 to 91ab7e6 Compare June 9, 2018 15:20
@Hate-Usernames Hate-Usernames force-pushed the tradfri-combine-commands branch from 0c5a7a9 to b79a7c5 Compare June 9, 2018 16:13
@Hate-Usernames Hate-Usernames changed the title WIP: pytradfri 5.5: Improved 3rd party bulb support pytradfri 5.5.1: Improved 3rd party bulb support Jun 9, 2018
pvizeli
pvizeli approved these changes Jun 13, 2018
View reviewed changes
Copy link
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work !

@pvizeli pvizeli merged commit a373793 into home-assistant:dev Jun 13, 2018
@ghost ghost removed the in progress label Jun 13, 2018
@Hate-Usernames Hate-Usernames deleted the tradfri-combine-commands branch June 13, 2018 08:59
awarecan pushed a commit to awarecan/home-assistant that referenced this pull request Jun 13, 2018
@Hate-Usernames @awarecan
pytradfri 5.5.1: Improved 3rd party bulb support (home-assistant#14887)
4a4382c 
* Bump pytradfri version

* Update light component

* Add tests

* lint

* Docstring typos

* Blank line

* lint

* 5.5.1

* Fix tests on py3.5
@balloob balloob mentioned this pull request Jun 22, 2018
Merged
@FezVrasta
Copy link
Contributor

Hey, my issue #14554 was closed by this PR, but I still reproduce the exact same problem. Any chance my issue could be re-open?

@FezVrasta FezVrasta mentioned this pull request Jul 31, 2018
Closed
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@Hate-Usernames
pytradfri 5.5.1: Improved 3rd party bulb support (home-assistant#14887)
ff94a29 
* Bump pytradfri version

* Update light component

* Add tests

* lint

* Docstring typos

* Blank line

* lint

* 5.5.1

* Fix tests on py3.5
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
@ghost ghost removed the platform: light.tradfri label Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
cla-signed integration: tradfri
Projects
None yet
Milestone
No milestone
4 participants
@Hate-Usernames @FezVrasta @pvizeli @homeassistant