Remove host/netsh commands from docker directives #11133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added -p 8123:8123 to the Windows docker command line. Seems more reliable and easier for users. Add ports to docker-compose.yaml files for easier launches..
frenck
requested changes
Nov 11, 2019
There was a problem hiding this comment.
Hi there, @datdamnzotz!
Thanks for the PR, however, we need to advise to run Home Assistant on the host network for various reasons.
The shares part is a really useful addition though, so maybe you could revert the host network/port mapping part? 👍
frenck
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added -p 8123:8123 to the Windows docker command line. Seems more reliable and easier for users.
Add ports to docker-compose.yaml files for easier launches..
Description:
Pull request in home-assistant (if applicable): home-assistant/home-assistant#
Checklist:
nextis for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.