-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Update google_assistant JavaScript to support local query. Remove onP… #21491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Omg, after troubleshooting for ages, this finally made my GA firing local commands! thn and confirmed working!! |
Because the core PR has already been merged in 2022.2, this PR should actually be in the |
…roxySelected, an undocumented function that seems to have broken functionality on newer GA Local SDK versions. Update docs to reflect changes. Fix list in markdown.
607d7b0
to
696b051
Compare
The reasons proxy selected check is not needed is because it is now handled in HA: home-assistant/core#65094. |
@bachya Does this still need to be rebased? It looks OK to me now. |
The branching looks good as far as I can see. Apologies: I closed this PR by accident earlier, so that's why you saw it reopened. |
@marcusds , can i contact you on community / discord? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @marcusds 👍
Something went wrong with the deployment of this change. It seems the See https://www.home-assistant.io/assets/integrations/google_assistant/app.js |
That is caching, will resolve itself |
Maybe I should have made the link with a version query string a la |
That's better indeed, or maybe just another filename? |
Proposed change
Enable local query for google_assistant, the functionality is identical to cloud query, so adding the functionality only requires updating the JavaScript that runs on the assistant devices and configuration change.
Also a fix to remove
onProxySelected
. This change was the only way I could make google_assistant local fulfilment work on any of my devices, but I would like to see others results with this. Two years ago this seemed to be a requirement, but none of Google's own docs or examples use it anymore.Type of change
current
branch).current
branch).next
branch).next
branch).This is a little unclear which type of change because code is included in this documentation.
I would like to longer term look at serving the JavaScript from Home Assistant itself. That will result in easier setup for users (just setting a URL in the Google Assistant developer panel, rather than uploading code) and more importantly code living with code not documentation.
Additional information
This builds on home-assistant/core#63218
Checklist
current
branch.next
branch.