Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update google_assistant JavaScript to support local query. Remove onP… #21491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 15, 2022

Conversation

marcusds
Copy link
Contributor

@marcusds marcusds commented Feb 4, 2022

Proposed change

Enable local query for google_assistant, the functionality is identical to cloud query, so adding the functionality only requires updating the JavaScript that runs on the assistant devices and configuration change.

Also a fix to remove onProxySelected. This change was the only way I could make google_assistant local fulfilment work on any of my devices, but I would like to see others results with this. Two years ago this seemed to be a requirement, but none of Google's own docs or examples use it anymore.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

This is a little unclear which type of change because code is included in this documentation.
I would like to longer term look at serving the JavaScript from Home Assistant itself. That will result in easier setup for users (just setting a URL in the Google Assistant developer panel, rather than uploading code) and more importantly code living with code not documentation.

Additional information

This builds on home-assistant/core#63218

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Feb 4, 2022
@pergolafabio
Copy link
Contributor

Omg, after troubleshooting for ages, this finally made my GA firing local commands! thn and confirmed working!!
I changed the .js file + ticked 'local support query'

@klaasnicolaas
Copy link
Member

Because the core PR has already been merged in 2022.2, this PR should actually be in the current branch.

…roxySelected, an undocumented function that seems to have broken functionality on newer GA Local SDK versions. Update docs to reflect changes. Fix list in markdown.
@raman325 raman325 requested review from a team and removed request for OttoWinter, TomBrien, farmio, Quentame, ludeeus, klaasnicolaas, Kane610, mib1185 and chemelli74 February 10, 2022 16:55
@balloob
Copy link
Member

balloob commented Feb 10, 2022

The reasons proxy selected check is not needed is because it is now handled in HA: home-assistant/core#65094.

@bachya bachya closed this Feb 10, 2022
@probot-home-assistant probot-home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Feb 10, 2022
@bachya bachya reopened this Feb 10, 2022
@marcusds
Copy link
Contributor Author

@bachya Does this still need to be rebased? It looks OK to me now.

@bachya
Copy link
Contributor

bachya commented Feb 10, 2022

The branching looks good as far as I can see. Apologies: I closed this PR by accident earlier, so that's why you saw it reopened.

@pergolafabio
Copy link
Contributor

@marcusds , can i contact you on community / discord?

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marcusds 👍

@frenck frenck merged commit 2ac836a into home-assistant:current Feb 15, 2022
@michaelarnauts
Copy link
Contributor

Something went wrong with the deployment of this change. It seems the app.js file in the assets is still the old one.

See https://www.home-assistant.io/assets/integrations/google_assistant/app.js

@frenck
Copy link
Member

frenck commented Feb 15, 2022

That is caching, will resolve itself

@marcusds
Copy link
Contributor Author

That is caching, will resolve itself

Maybe I should have made the link with a version query string a la https://www.home-assistant.io/assets/integrations/google_assistant/app.js?v=1.1.0

@pergolafabio
Copy link
Contributor

That's better indeed, or maybe just another filename?

@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants