Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add note regarding SamsungTV sources #22115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2022
Merged

Add note regarding SamsungTV sources #22115

merged 2 commits into from
Mar 22, 2022

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Mar 22, 2022 •
edited
Loading

Proposed change

Add note regarding SamsungTV sources. Newer models simply ignore the request.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@epenet epenet requested a review from chemelli74 as a code owner March 22, 2022 10:41
@probot-home-assistant probot-home-assistant bot added the has-parent This PR has a parent PR in a other repo label Mar 22, 2022
@probot-home-assistant probot-home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Mar 22, 2022
@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Mar 22, 2022
@probot-home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.
(message by DocsTargetBranch)

@epenet
Copy link
Contributor Author

epenet commented Mar 22, 2022

Refs: home-assistant/core#66752, home-assistant/core#68114, home-assistant/core#68235, home-assistant/core#68506

@epenet epenet removed has-parent This PR has a parent PR in a other repo needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Mar 22, 2022
frenck
frenck reviewed Mar 22, 2022
View reviewed changes
frenck
frenck approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 👍

@frenck frenck merged commit da8b51a into current Mar 22, 2022
@frenck frenck deleted the epenet-patch-2 branch March 22, 2022 11:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@chemelli74 chemelli74 Awaiting requested review from chemelli74 chemelli74 is a code owner

Assignees

@epenet epenet

Labels
cla-signed current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epenet @frenck @homeassistant