Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Create device_tracker.huawei_router.markdown #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 12, 2017

Conversation

abmantis
Copy link
Member

@abmantis abmantis commented Jul 16, 2017

Description:

Pull request in home-assistant (if applicable): home-assistant/core#8488

Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good and can be merged after the logo has been updated and the parent PR has been merged.

comments: false
sharing: true
footer: true
logo: bt.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this i the wrong logo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Missed that. Is there a way to upload a logo without forking the repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go to your fork, upload a new file with the github GUI and it will be added to the same PR.

@Landrash Landrash added the new-integration This PR adds documentation for a new Home Assistant integration label Jul 17, 2017
@balloob balloob changed the base branch from current to next August 12, 2017 19:53
@balloob
Copy link
Member

balloob commented Aug 12, 2017

Had to change base branch of PR and add Hass version tag.

@balloob balloob merged commit 18e81c1 into home-assistant:next Aug 12, 2017
balloob pushed a commit that referenced this pull request Aug 12, 2017
* Create device_tracker.huawei_router.markdown

* Update device_tracker.huawei_router.markdown

* add huawei logo

* Update device_tracker.huawei_router.markdown

* Update device_tracker.huawei_router.markdown
@abmantis abmantis deleted the patch-1 branch August 12, 2017 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants