Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Switcher Runner S11 support #34269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

YogevBokobza
Copy link
Contributor

@YogevBokobza YogevBokobza commented Aug 12, 2024

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Enhanced documentation for the Switcher integration, including an updated list of supported devices with the addition of the Switcher Runner S11.
    • Added a new section detailing requirements for operating token-based devices, including instructions for obtaining a local control key token.
    • Updated guidance on firewall settings to include an additional UDP port (10003) for better configuration.

@YogevBokobza YogevBokobza requested a review from thecode as a code owner August 12, 2024 16:36
@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Aug 12, 2024
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

Copy link
Contributor

coderabbitai bot commented Aug 12, 2024

Warning

Rate limit exceeded

@c0ffeeca7 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 8 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 7877e22 and 87da51b.

Walkthrough

Walkthrough

The updates to the Switcher integration documentation include the addition of the Switcher Runner S11 to the list of supported devices and a new section detailing the prerequisites for using token-based devices, specifically the need for a username and local control key token. Additionally, the firewall guidance has been updated to include UDP port 10003, ensuring comprehensive support for users configuring their Home Assistant environment with Switcher devices.

Changes

File Path Change Summary
source/_integrations/switcher_kis.markdown Added Switcher Runner S11 to the list of supported devices, introduced a section for token requirements, and updated firewall guidance to include UDP port 10003.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HomeAssistant
    participant SwitcherAPI

    User->>HomeAssistant: Request to configure Switcher device
    HomeAssistant->>SwitcherAPI: Obtain token (GetKey API)
    SwitcherAPI-->>HomeAssistant: Provide username and local control key token
    HomeAssistant-->>User: Configuration complete
Loading

Assessment against linked issues

Objective Addressed Explanation
Add support for new devices (Issue #1)
Clarify prerequisites for token usage (Issue #2)
Update firewall settings (Issue #3)

Possibly related issues


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 87da51b
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/66f112ed37ddfc0008163604
😎 Deploy Preview https://deploy-preview-34269--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@home-assistant home-assistant bot removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Aug 12, 2024
@home-assistant home-assistant bot added the has-parent This PR has a parent PR in a other repo label Aug 12, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Outside diff range, codebase verification and nitpick comments (1)
source/_integrations/switcher_kis.markdown (1)

49-49: Remove trailing space.

There is a trailing space at the end of the line, which should be removed to adhere to markdownlint rules.

- To use your Switcher token-based devices with Home Assistant, 
+ To use your Switcher token-based devices with Home Assistant,
Tools
Markdownlint

49-49: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)

@thecode thecode changed the title switcher update doc to runner S11 Add Switcher Runner S11 support Aug 13, 2024
@YogevBokobza YogevBokobza force-pushed the swiitcher-s11-support branch from e1794b3 to b1e05b6 Compare August 13, 2024 20:26
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @YogevBokobza 👍

@c0ffeeca7 c0ffeeca7 merged commit 76674d6 into home-assistant:next Sep 23, 2024
6 checks passed
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Sep 23, 2024
@YogevBokobza YogevBokobza deleted the swiitcher-s11-support branch September 23, 2024 07:29
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants