-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Remove core specific documentation from integrations #39311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
📝 WalkthroughWalkthroughThis update revises documentation across several Home Assistant integration files, primarily removing or altering instructions, notes, and requirements specific to "Home Assistant Core" installations. The changes eliminate references to Home Assistant Core in installation, troubleshooting, and configuration guidance, focusing instructions on other installation methods such as OS, Supervised, and Container. Changes
Sequence Diagram(s)No sequence diagram is generated as the changes are limited to documentation updates and do not introduce or modify control flow or features. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
source/_integrations/energenie_power_sockets.markdown (1)
23-23
: Suggestion: Improve sentence formatting for consistency
Consider replacing the colon after “installation” with a comma and tightening the phrasing to match the style used elsewhere in the docs:- If you are running a {% term "Home Assistant Container" %} installation: Depending on your system configuration, it may be necessary to grant explicit user access rights to the USB device by creating an udev rule. + If you are running a {% term "Home Assistant Container" %} installation, you may need to grant explicit user access rights to the USB device by creating an udev rule.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (9)
source/_integrations/beewi_smartclim.markdown
(0 hunks)source/_integrations/energenie_power_sockets.markdown
(1 hunks)source/_integrations/matter.markdown
(0 hunks)source/_integrations/media_source.markdown
(0 hunks)source/_integrations/onvif.markdown
(0 hunks)source/_integrations/ps4.markdown
(0 hunks)source/_integrations/sql.markdown
(0 hunks)source/_integrations/zerproc.markdown
(0 hunks)source/_integrations/zwave_js.markdown
(1 hunks)
💤 Files with no reviewable changes (7)
- source/_integrations/sql.markdown
- source/_integrations/beewi_smartclim.markdown
- source/_integrations/zerproc.markdown
- source/_integrations/ps4.markdown
- source/_integrations/media_source.markdown
- source/_integrations/onvif.markdown
- source/_integrations/matter.markdown
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/energenie_power_sockets.markdown (1)
23-23
: Removal of deprecated "Home Assistant Core" guidance
This update correctly scopes the udev rule instructions to only "Home Assistant Container" installations, aligning with the broader effort to drop unsupported Core-specific documentation.
@@ -752,7 +752,7 @@ In addition to the [standard automation trigger data](/docs/automation/templatin | |||
|
|||
## Advanced installation instructions | |||
|
|||
If you are using Home Assistant Container, Home Assistant Core, or you don't want to use the built-in Z-Wave JS Server add-on, you will need to run the Z-Wave JS server yourself, to which the Z-Wave integration will connect. | |||
If you are using Home Assistant Container or you don't want to use the built-in Z-Wave JS Server add-on, you will need to run the Z-Wave JS server yourself, to which the Z-Wave integration will connect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Remove deprecated Home Assistant Core reference
This change correctly strips out the unsupported “Home Assistant Core” mention, focusing the advanced installation guidance on Container and add-on usage as intended by the PR. Please verify there are no remaining “Home Assistant Core” references in this file.
🏁 Script executed:
#!/bin/bash
# Check for any lingering Core mentions in this doc
rg -n "Home Assistant Core" source/_integrations/zwave_js.markdown
Length of output: 264
Remove remaining “Home Assistant Core” reference
The ripgrep search found one more instance that needs updating:
- source/_integrations/zwave_js.markdown:922
Replace:with:…after a restart of Home Assistant Core…
…after a restart of Home Assistant…
🤖 Prompt for AI Agents
In source/_integrations/zwave_js.markdown around line 922, update the phrase
"after a restart of Home Assistant Core" to "after a restart of Home Assistant"
to remove the deprecated "Home Assistant Core" reference and maintain
consistency with the rest of the document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @edenhaus 👍
Proposed change
Remove core specific documentation form integrations as core is not supported anymore
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit