-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Update join-the-community.markdown #39334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
Adds link to Home Assistant Cookbook
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughA new bullet point linking to the "Home Assistant Cookbook" forum page was added to the community resources list in the documentation. No other content or structure was changed. Changes
Sequence Diagram(s)No sequence diagram is generated as the change is a documentation update without control flow or feature logic. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/getting-started/join-the-community.markdown (1)
12-12
: Unify link style and phrasing for consistency
The new bullet currently uses an inline link and “Have a look at the forum’s…”, whereas other items employ reference-style links and slightly different wording. To align with existing conventions, consider:
- Converting to a reference link by adding at the bottom:
[home-assistant-cookbook]: https://community.home-assistant.io/t/the-home-assistant-cookbook-index/707144- Updating the bullet to:
- Take a look in [our forums] at the Home Assistant Cookbook [home-assistant-cookbook]This change will maintain link-definition consistency and use the more common American English idiom.
🧰 Tools
🪛 LanguageTool
[locale-violation] ~12-~12: In American English, “take a look” is more commonly used.
Context: ...unity in [our forums] or [our chat]. - Have a look at the forum's [Home Assistant Cookbook...(HAVE_A_LOOK)
🪛 markdownlint-cli2 (0.17.2)
12-12: Unordered list indentation
Expected: 0; Actual: 1(MD007, ul-indent)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/getting-started/join-the-community.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/getting-started/join-the-community.markdown
[locale-violation] ~12-~12: In American English, “take a look” is more commonly used.
Context: ...unity in [our forums] or [our chat]. - Have a look at the forum's [Home Assistant Cookbook...
(HAVE_A_LOOK)
🪛 markdownlint-cli2 (0.17.2)
source/getting-started/join-the-community.markdown
12-12: Unordered list indentation
Expected: 0; Actual: 1
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
- GitHub Check: Lint Markdown
@@ -9,6 +9,7 @@ Now that you've got that going, let's see what is next: | |||
|
|||
- Learn about [next steps](/getting-started/configuration/) of the getting started guide, such as creating a backup or configuring network storage. | |||
- Join the community in [our forums] or [our chat]. | |||
- Have a look at the forum's [Home Assistant Cookbook](https://community.home-assistant.io/t/the-home-assistant-cookbook-index/707144) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the effort, but if that guide contain things someone would need, we should add the to the documentation instead of linking away from it.
../Frenck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your response. Not sure how to interpret it - are you saying that the things in the Home Assistant Cookbook are not "needed".
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Adds link to Home Assistant Cookbook
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit