-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Make Tesla Fleet documentation easier to follow #39440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe Tesla Fleet integration documentation was substantially revised for clarity and completeness. The update restructures setup instructions, expands on prerequisites, details key generation and hosting, clarifies developer application and partner registration steps, updates polling and billing information, and reorganizes troubleshooting and removal guidance to reflect Tesla's latest API and billing policies. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeAssistant
participant TeslaAPI
participant WebHost/NGINX
User->>HomeAssistant: Initiate Tesla Fleet integration setup
HomeAssistant->>User: Display prerequisites and key generation steps
User->>WebHost/NGINX: Host public key as instructed
User->>TeslaAPI: Register Developer Application and domain
User->>HomeAssistant: Input credentials and complete integration linking
HomeAssistant->>TeslaAPI: Authenticate and link account
HomeAssistant->>TeslaAPI: Poll for vehicle data (respecting interval/billing)
HomeAssistant->>User: Display vehicle controls and sensor data
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
source/_integrations/tesla_fleet.markdown (4)
43-48
: Enhance prerequisites clarity and define MFA.
- Specify that the public key must be hosted on a publicly accessible domain.
- Consider appending “(MFA)” after multi-factor authentication and hyphenate “multi-factor” consistently, or use “multifactor authentication” per style.
Apply this diff:
- You need to configure developer credentials and host a public key file to allow Home Assistant to communicate with your Tesla account. + You need to configure developer credentials and host your public key on a publicly accessible domain so Home Assistant can communicate with your Tesla account. - - A [Tesla](https://tesla.com) account with verified email and multi-factor authentication + - A [Tesla](https://tesla.com) account with verified email and multi-factor authentication (MFA)🧰 Tools
🪛 LanguageTool
[misspelling] ~45-~45: This word is normally spelled as one.
Context: ...la.com) account with verified email and multi-factor authentication - A web domain to host y...(EN_COMPOUNDS_MULTI_FACTOR)
119-119
: Correct verb usage: “Back up” vs “Backup.”
Use the verb form “back up” when describing the action:- 10. **Backup your keys** in a safe location for future use. + 10. **Back up your keys** in a safe location for future use.🧰 Tools
🪛 LanguageTool
[grammar] ~119-~119: The word ‘Backup’ is a noun. Do you mean the verb “Back up”?
Context: ...fic/com.tesla.3p.public-key.pem` 10. Backup your keys in a safe location for futu...(SENT_START_BACKUP)
🪛 markdownlint-cli2 (0.17.2)
119-119: Ordered list item prefix
Expected: 4; Actual: 10; Style: 1/2/3(MD029, ol-prefix)
162-162
: Correct verb usage: “Back up.”- 7. **Backup both key files** in a safe location for future use. + 7. **Back up both key files** in a safe location for future use.🧰 Tools
🪛 LanguageTool
[grammar] ~162-~162: The word ‘Backup’ is a noun. Do you mean the verb “Back up”?
Context: ...ant/config/tesla_fleet.key ``` 7. Backup both key files in a safe location for...(SENT_START_BACKUP)
🪛 markdownlint-cli2 (0.17.2)
162-162: Ordered list item prefix
Expected: 3; Actual: 7; Style: 1/2/3(MD029, ol-prefix)
317-317
: Correct verb usage: “set up” vs “setup.”- ... and the key has not been setup correctly. + ... and the key has not been set up correctly.🧰 Tools
🪛 LanguageTool
[grammar] ~317-~317: Make sure that the noun ‘setup’ is correct. Did you mean the past participle “set up”?
Context: ...is is required and the key has not been setup correctly. The {% term integration %} ...(BE_VB_OR_NN)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/tesla_fleet.markdown
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/tesla_fleet.markdown
[misspelling] ~45-~45: This word is normally spelled as one.
Context: ...la.com) account with verified email and multi-factor authentication - A web domain to host y...
(EN_COMPOUNDS_MULTI_FACTOR)
[grammar] ~119-~119: The word ‘Backup’ is a noun. Do you mean the verb “Back up”?
Context: ...fic/com.tesla.3p.public-key.pem` 10. Backup your keys in a safe location for futu...
(SENT_START_BACKUP)
[grammar] ~162-~162: The word ‘Backup’ is a noun. Do you mean the verb “Back up”?
Context: ...ant/config/tesla_fleet.key ``` 7. Backup both key files in a safe location for...
(SENT_START_BACKUP)
[misspelling] ~172-~172: This word is normally spelled as one.
Context: ...- Verify your email address - Enable multi-factor authentication 2. **Create a new appli...
(EN_COMPOUNDS_MULTI_FACTOR)
[uncategorized] ~216-~216: You might be missing the article “a” here.
Context: ...Home Assistant ### Step 3: Register as Tesla Fleet API partner Before you can use y...
(AI_EN_LECTOR_MISSING_DETERMINER_A)
[uncategorized] ~249-~249: Possible missing comma found.
Context: ... $
characters, you may need to escape them depending on your terminal. {% endno...
(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~301-~301: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...tes The {% term integration %} {% term polling polls %} each vehicle every 10 minutes while ...
(REPEATED_VERBS)
[grammar] ~317-~317: Make sure that the noun ‘setup’ is correct. Did you mean the past participle “set up”?
Context: ...is is required and the key has not been setup correctly. The {% term integration %} ...
(BE_VB_OR_NN)
[uncategorized] ~485-~485: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...lic key is accessible at the correct URL and you've completed all registration steps...
(COMMA_COMPOUND_SENTENCE)
🪛 Gitleaks (8.26.0)
source/_integrations/tesla_fleet.markdown
263-265: Discovered a potential authorization token provided in a curl command header, which could compromise the curl accessed resource.
(curl-auth-header)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/tesla_fleet.markdown
56-56: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
83-83: Ordered list item prefix
Expected: 1; Actual: 4; Style: 1/2/3
(MD029, ol-prefix)
89-89: Ordered list item prefix
Expected: 2; Actual: 5; Style: 1/2/3
(MD029, ol-prefix)
95-95: Ordered list item prefix
Expected: 3; Actual: 6; Style: 1/2/3
(MD029, ol-prefix)
103-103: Ordered list item prefix
Expected: 1; Actual: 7; Style: 1/2/3
(MD029, ol-prefix)
111-111: Ordered list item prefix
Expected: 2; Actual: 8; Style: 1/2/3
(MD029, ol-prefix)
116-116: Ordered list item prefix
Expected: 3; Actual: 9; Style: 1/2/3
(MD029, ol-prefix)
119-119: Ordered list item prefix
Expected: 4; Actual: 10; Style: 1/2/3
(MD029, ol-prefix)
149-149: Ordered list item prefix
Expected: 1; Actual: 5; Style: 1/2/3
(MD029, ol-prefix)
156-156: Ordered list item prefix
Expected: 2; Actual: 6; Style: 1/2/3
(MD029, ol-prefix)
162-162: Ordered list item prefix
Expected: 3; Actual: 7; Style: 1/2/3
(MD029, ol-prefix)
260-260: Ordered list item prefix
Expected: 1; Actual: 5; Style: 1/2/3
(MD029, ol-prefix)
271-271: Ordered list item prefix
Expected: 2; Actual: 6; Style: 1/2/3
(MD029, ol-prefix)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (7)
source/_integrations/tesla_fleet.markdown (7)
39-39
: Introduction is clear. The revised opening effectively frames the integration capabilities without losing context.
54-63
: Skip restructured headings/details block. No action needed here.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
56-56: Multiple consecutive blank lines
Expected: 1; Actual: 2(MD012, no-multiple-blanks)
216-218
: Skip: registration headings. The phrasing is clear and the article is present.🧰 Tools
🪛 LanguageTool
[uncategorized] ~216-~216: You might be missing the article “a” here.
Context: ...Home Assistant ### Step 3: Register as Tesla Fleet API partner Before you can use y...(AI_EN_LECTOR_MISSING_DETERMINER_A)
263-265
: Skip: placeholder credentials in curl command. No real token exposed.🧰 Tools
🪛 Gitleaks (8.26.0)
263-265: Discovered a potential authorization token provided in a curl command header, which could compromise the curl accessed resource.
(curl-auth-header)
299-299
: Skip: “## Data updates” heading. No issues.
303-305
: Skip: billing note block. Content is accurate and clear.
301-301
:⚠️ Potential issueFix duplicate templating in polling sentence.
The current text repeats “polls” twice. It should read:- The {% term integration %} {% term polling polls %} each vehicle every 10 minutes while it's awake. + The {% term integration %} polls each vehicle every 10 minutes while it's awake.Likely an incorrect or invalid review comment.
🧰 Tools
🪛 LanguageTool
[grammar] ~301-~301: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...tes The {% term integration %} {% term polling polls %} each vehicle every 10 minutes while ...(REPEATED_VERBS)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (6)
source/_integrations/tesla_fleet.markdown (6)
43-48
: Strengthen clarity in prerequisites wording.
Consider changing "host a public key file" to "host your public key file" to more directly tie the step to the user’s configuration.
120-120
: Correct "Backup" to "Back up" for the verb.
Change "Backup your keys" → "Back up your keys" to use the correct verb form.
162-162
: Correct "Backup" to "Back up" for the verb.
Change "Backup both key files" → "Back up both key files" for consistency with verb usage.🧰 Tools
🪛 LanguageTool
[grammar] ~162-~162: The word ‘Backup’ is a noun. Do you mean the verb “Back up”?
Context: ...ant/config/tesla_fleet.key ``` 7. Backup both key files in a safe location for...(SENT_START_BACKUP)
🪛 markdownlint-cli2 (0.17.2)
162-162: Ordered list item prefix
Expected: 3; Actual: 7; Style: 1/2/3(MD029, ol-prefix)
219-223
: Enhance heading grammar.
In the heading, add the article "a":### Step 3: Register as a Tesla Fleet API partner
306-306
: Remove redundant term for polling.
The phrase{% term polling polls %}
is repetitive. Simplify to "polls each vehicle every 10 minutes".🧰 Tools
🪛 LanguageTool
[grammar] ~306-~306: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...tes The {% term integration %} {% term polling polls %} each vehicle every 10 minutes while ...(REPEATED_VERBS)
322-322
: Use correct verb form for "set up".
Change "has not been setup correctly" → "has not been set up correctly".🧰 Tools
🪛 LanguageTool
[grammar] ~322-~322: Make sure that the noun ‘setup’ is correct. Did you mean the past participle “set up”?
Context: ...is is required and the key has not been setup correctly. The {% term integration %} ...(BE_VB_OR_NN)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/tesla_fleet.markdown
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/tesla_fleet.markdown
[grammar] ~119-~119: The word ‘Backup’ is a noun. Do you mean the verb “Back up”?
Context: ...fic/com.tesla.3p.public-key.pem` 10. Backup your keys in a safe location for futu...
(SENT_START_BACKUP)
[grammar] ~162-~162: The word ‘Backup’ is a noun. Do you mean the verb “Back up”?
Context: ...ant/config/tesla_fleet.key ``` 7. Backup both key files in a safe location for...
(SENT_START_BACKUP)
[misspelling] ~172-~172: This word is normally spelled as one.
Context: ...- Verify your email address - Enable multi-factor authentication (optional) 2. **Create ...
(EN_COMPOUNDS_MULTI_FACTOR)
[uncategorized] ~218-~218: You might be missing the article “a” here.
Context: ...Home Assistant ### Step 3: Register as Tesla Fleet API partner Before you can use y...
(AI_EN_LECTOR_MISSING_DETERMINER_A)
[uncategorized] ~254-~254: Possible missing comma found.
Context: ... $
characters, you may need to escape them depending on your terminal. {% endno...
(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~306-~306: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...tes The {% term integration %} {% term polling polls %} each vehicle every 10 minutes while ...
(REPEATED_VERBS)
[grammar] ~322-~322: Make sure that the noun ‘setup’ is correct. Did you mean the past participle “set up”?
Context: ...is is required and the key has not been setup correctly. The {% term integration %} ...
(BE_VB_OR_NN)
[uncategorized] ~490-~490: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...lic key is accessible at the correct URL and you've completed all registration steps...
(COMMA_COMPOUND_SENTENCE)
🪛 Gitleaks (8.26.0)
source/_integrations/tesla_fleet.markdown
268-270: Discovered a potential authorization token provided in a curl command header, which could compromise the curl accessed resource.
(curl-auth-header)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/tesla_fleet.markdown
56-56: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
83-83: Ordered list item prefix
Expected: 1; Actual: 4; Style: 1/2/3
(MD029, ol-prefix)
89-89: Ordered list item prefix
Expected: 2; Actual: 5; Style: 1/2/3
(MD029, ol-prefix)
95-95: Ordered list item prefix
Expected: 3; Actual: 6; Style: 1/2/3
(MD029, ol-prefix)
103-103: Ordered list item prefix
Expected: 1; Actual: 7; Style: 1/2/3
(MD029, ol-prefix)
111-111: Ordered list item prefix
Expected: 2; Actual: 8; Style: 1/2/3
(MD029, ol-prefix)
116-116: Ordered list item prefix
Expected: 3; Actual: 9; Style: 1/2/3
(MD029, ol-prefix)
119-119: Ordered list item prefix
Expected: 4; Actual: 10; Style: 1/2/3
(MD029, ol-prefix)
149-149: Ordered list item prefix
Expected: 1; Actual: 5; Style: 1/2/3
(MD029, ol-prefix)
156-156: Ordered list item prefix
Expected: 2; Actual: 6; Style: 1/2/3
(MD029, ol-prefix)
162-162: Ordered list item prefix
Expected: 3; Actual: 7; Style: 1/2/3
(MD029, ol-prefix)
265-265: Ordered list item prefix
Expected: 1; Actual: 5; Style: 1/2/3
(MD029, ol-prefix)
276-276: Ordered list item prefix
Expected: 2; Actual: 6; Style: 1/2/3
(MD029, ol-prefix)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (10)
source/_integrations/tesla_fleet.markdown (10)
39-39
: Concise API description is clear and accurate.
The updated description emphasizes control capabilities over Tesla vehicles and energy sites.
50-51
: Prerequisites note is concise and informative.
The note clearly outlines the overall setup process without adding unnecessary complexity.
54-54
: Configuration section header is properly placed.
Clear separation into a dedicated Configuration section improves document structure.
57-63
: Setup introduction and step overview are well structured.
The intro sentence and "Step 1" callout set clear expectations for the following instructions.
63-121
: NGINX proxy add-on instructions are clear and actionable.
The detailed shell commands, configuration edits, and verification steps match Home Assistant patterns.🧰 Tools
🪛 LanguageTool
[grammar] ~119-~119: The word ‘Backup’ is a noun. Do you mean the verb “Back up”?
Context: ...fic/com.tesla.3p.public-key.pem` 10. Backup your keys in a safe location for futu...(SENT_START_BACKUP)
🪛 markdownlint-cli2 (0.17.2)
83-83: Ordered list item prefix
Expected: 1; Actual: 4; Style: 1/2/3(MD029, ol-prefix)
89-89: Ordered list item prefix
Expected: 2; Actual: 5; Style: 1/2/3(MD029, ol-prefix)
95-95: Ordered list item prefix
Expected: 3; Actual: 6; Style: 1/2/3(MD029, ol-prefix)
103-103: Ordered list item prefix
Expected: 1; Actual: 7; Style: 1/2/3(MD029, ol-prefix)
111-111: Ordered list item prefix
Expected: 2; Actual: 8; Style: 1/2/3(MD029, ol-prefix)
116-116: Ordered list item prefix
Expected: 3; Actual: 9; Style: 1/2/3(MD029, ol-prefix)
119-119: Ordered list item prefix
Expected: 4; Actual: 10; Style: 1/2/3(MD029, ol-prefix)
124-164
: External hosting instructions are comprehensive and accurate.
Alternative hosting method is well documented with clear path requirements and verification notes.🧰 Tools
🪛 LanguageTool
[grammar] ~162-~162: The word ‘Backup’ is a noun. Do you mean the verb “Back up”?
Context: ...ant/config/tesla_fleet.key ``` 7. Backup both key files in a safe location for...(SENT_START_BACKUP)
🪛 markdownlint-cli2 (0.17.2)
149-149: Ordered list item prefix
Expected: 1; Actual: 5; Style: 1/2/3(MD029, ol-prefix)
156-156: Ordered list item prefix
Expected: 2; Actual: 6; Style: 1/2/3(MD029, ol-prefix)
162-162: Ordered list item prefix
Expected: 3; Actual: 7; Style: 1/2/3(MD029, ol-prefix)
166-169
: Developer application setup steps are clear and detailed.
High-level guidance and prerequisites are well laid out before diving into application creation.
171-217
: Application creation subsections are well organised.
The breakdown into account setup, application details, OAuth configuration, scopes, and billing aligns with best practices.🧰 Tools
🪛 LanguageTool
[misspelling] ~172-~172: This word is normally spelled as one.
Context: ...- Verify your email address - Enable multi-factor authentication (optional) 2. **Create ...(EN_COMPOUNDS_MULTI_FACTOR)
226-253
: Access token retrieval commands are correctly formatted.
All curl flags, headers, and data-urlencode options align with Tesla’s requirements.
264-272
: Partner registration cURL command is accurate.
The JSON payload and Authorization header usage are clear and well-documented.🧰 Tools
🪛 Gitleaks (8.26.0)
268-270: Discovered a potential authorization token provided in a curl command header, which could compromise the curl accessed resource.
(curl-auth-header)
🪛 markdownlint-cli2 (0.17.2)
265-265: Ordered list item prefix
Expected: 1; Actual: 5; Style: 1/2/3(MD029, ol-prefix)
are you still working on this, @Bre77 ? Asking because it is in Draft mode |
Yeah I found some inaccuracies so I need to manually review this again. It's on my to do list. |
Proposed change
I have seen lots of comments about how the Tesla Fleet documentation is difficult to follow. I used Claude 4 to read Spotify and Google Drive then improve Tesla Fleets documentation
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit