Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Z-Wave: update steps on changing log levels to reflect current SW #39468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025

Conversation

c0ffeeca7
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 commented Jun 10, 2025

Proposed change

adjust steps to include Log tab on configuration page

image

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Expanded and restructured the instructions for enabling Z-Wave JS logging, providing a more detailed, step-by-step guide with navigation details and log level configuration.
    • Added a related link to Z-Wave controllers documentation.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Jun 10, 2025
Copy link

netlify bot commented Jun 10, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit daf3b5f
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/68488ad06b6c9e0008f88852
😎 Deploy Preview https://deploy-preview-39468--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@c0ffeeca7 c0ffeeca7 marked this pull request as ready for review June 10, 2025 19:43
@c0ffeeca7 c0ffeeca7 requested a review from a team as a code owner June 10, 2025 19:43
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @c0ffeeca7 👍

../Frenck

Copy link
Contributor

coderabbitai bot commented Jun 10, 2025

📝 Walkthrough

Walkthrough

The documentation for enabling Z-Wave JS logging in Home Assistant was expanded and reorganized. The update replaces a brief two-step instruction with a detailed, step-by-step guide for setting log levels and enabling debug logging. An additional link to related Z-Wave controller documentation was also introduced.

Changes

File(s) Change Summary
source/_integrations/zwave_js.markdown Expanded and restructured logging instructions; added navigation details and a related docs link

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HomeAssistant_UI

    User->>HomeAssistant_UI: Navigate to Settings > Devices & services > Z-Wave
    User->>HomeAssistant_UI: Select Configure
    User->>HomeAssistant_UI: Open Logs tab and set log level
    User->>HomeAssistant_UI: Return to Z-Wave integration panel
    User->>HomeAssistant_UI: Enable debug logging
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between fa6cd28 and daf3b5f.

📒 Files selected for processing (1)
  • source/_integrations/zwave_js.markdown (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/zwave_js.markdown (2)

47-49: Verify the new related docs entry
The added related section correctly links to the Z-Wave controllers documentation, but please confirm that /docs/z-wave/controllers/ resolves to the intended page and that the title casing (“Z-Wave controllers”) matches other integrations’ related links.


965-971: Confirm the UI tab name matches the text
The instructions refer to opening the Logs tab—verify whether the current Home Assistant interface labels it “Log” or “Logs” (singular vs. plural) and update the copy to exactly match the UI.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@c0ffeeca7 c0ffeeca7 merged commit 877c14c into current Jun 11, 2025
9 checks passed
@c0ffeeca7 c0ffeeca7 deleted the z-wave-update-log-steps branch June 11, 2025 08:34
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't a good change.


The log level will be set to `debug` for the integration, library, and optionally the driver (if the driver log level is not already set to `verbose`, `debug`, or `silly`), and all Z-Wave JS logs will be added to the Home Assistant logs.
1. Define the log level:
- By default, it is set to `info` for the integration, library, and optionally the driver (if the driver log level is not already set to `verbose`, `debug`, or `silly`), and all Z-Wave JS logs will be added to the Home Assistant logs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence doesn't make sense now. Before your change we described what happened when the log was set to debug. We should retain that.

- By default, it is set to `info` for the integration, library, and optionally the driver (if the driver log level is not already set to `verbose`, `debug`, or `silly`), and all Z-Wave JS logs will be added to the Home Assistant logs.
- Go to the {% my integration domain="zwave_js" title="**Settings** > **Devices & services** > **Z-Wave**" %} and select **Configure**.
- On the Z-Wave configuration page, open the **Logs** tab.
- Choose your log level.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed to just set the log level to debug. It's enough to do step 2 and 3.

If we want to expand on the logging feature I think it should be a separate paragraph that explains that you can customize the logging level of the driver. This is what's done from the logging panel in the config panel of the Z-Wave integration.

If the user just wants to capture debug logs for troubleshooting (the most common case) it's enough to follow the previous description.

@@ -959,10 +962,13 @@ Many users have reported issues with interference when the USB stick was directl

##### Enable Z-Wave JS logging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add "debug" here so that it becomes "Enable Z-Wave JS debug logging".

@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants