Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added Unifi direct doc. #4004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2017
Merged

Added Unifi direct doc. #4004

merged 2 commits into from
Nov 18, 2017

Conversation

w1ll1am23
Copy link
Contributor

@w1ll1am23 w1ll1am23 commented Nov 17, 2017

Description:
Added documentation on the Unifi direct device tracker.

I believe the rainbird file was modified because of line ending? I am submitting this from a Unix system and maybe it was pushed via Windows? I did a clean branch from home-assistant.github.io's next branch and this file shows as modified without me doing anything at all.

Pull request in home-assistant (if applicable): home-assistant/core#10097

Checklist:

@MartinHjelmare
Copy link
Member

If you didn't touch it and include it in the commit, it can't have a diff, if your base is the same as upstream next. So either of them is not true.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rainbird diff should be fixed. The configuration tag is preferred, but we're also getting close to the release, so I think it's OK to wait with that. Nevermind about the release. This feature was not included in 0.58, so it will go in 0.59.

password: YOUR_PASSWORD
```

Configuration variables:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartinHjelmare MartinHjelmare modified the milestone: 0.58 Nov 18, 2017
footer: true
logo: ubiquiti.png
ha_category: Presence Detection
ha_release: 0.58
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.59

@frenck frenck added this to the 0.59 milestone Nov 18, 2017
@w1ll1am23
Copy link
Contributor Author

w1ll1am23 commented Nov 18, 2017

@MartinHjelmare I tested again after opening this. I did a git clone of this repo into a clean directory. As soon as it finished I CDd into the directory. I did a git status and it says the file has changed. Everything matches up to what's going on here https://stackoverflow.com/questions/10017885/why-does-git-insist-that-a-file-has-been-modified-even-after-a-git-checkout

I just tried again and copied all my steps and I am seeing a whitespace error when rebasing upstream/next on to my forks next. Notice the git status commands which indicate nothing has changed prior to the rebase.

https://hastebin.com/efotuhebos.sql

@MartinHjelmare
Copy link
Member

Ok, I can reproduce the the change on the rainbird file by pulling upstream next. I'll try to fix that in another PR.

@MartinHjelmare
Copy link
Member

Line endings fix here:
#4009

@MartinHjelmare
Copy link
Member

@w1ll1am23 you were right about the windows line endings being the cause. But even though that file was changed you don't need to include it in your commit. So it should be possible to make this PR without that change.

@w1ll1am23
Copy link
Contributor Author

@MartinHjelmare Thanks, that worked.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🎉

@MartinHjelmare MartinHjelmare merged commit 524aa6c into home-assistant:next Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants