-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Added Unifi direct doc. #4004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Unifi direct doc. #4004
Conversation
If you didn't touch it and include it in the commit, it can't have a diff, if your base is the same as upstream next. So either of them is not true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rainbird diff should be fixed. The configuration tag is preferred, but we're also getting close to the release, so I think it's OK to wait with that. Nevermind about the release. This feature was not included in 0.58, so it will go in 0.59.
password: YOUR_PASSWORD | ||
``` | ||
|
||
Configuration variables: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preferably use the new configuration tag:
https://home-assistant.io/developers/documentation/standards/#component-and-platform-pages
footer: true | ||
logo: ubiquiti.png | ||
ha_category: Presence Detection | ||
ha_release: 0.58 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.59
@MartinHjelmare I tested again after opening this. I did a git clone of this repo into a clean directory. As soon as it finished I CDd into the directory. I did a git status and it says the file has changed. Everything matches up to what's going on here https://stackoverflow.com/questions/10017885/why-does-git-insist-that-a-file-has-been-modified-even-after-a-git-checkout I just tried again and copied all my steps and I am seeing a whitespace error when rebasing upstream/next on to my forks next. Notice the git status commands which indicate nothing has changed prior to the rebase. |
Ok, I can reproduce the the change on the rainbird file by pulling upstream next. I'll try to fix that in another PR. |
Line endings fix here: |
@w1ll1am23 you were right about the windows line endings being the cause. But even though that file was changed you don't need to include it in your commit. So it should be possible to make this PR without that change. |
@MartinHjelmare Thanks, that worked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🎉
Description:
Added documentation on the Unifi direct device tracker.
I believe the rainbird file was modified because of line ending? I am submitting this from a Unix system and maybe it was pushed via Windows? I did a clean branch from home-assistant.github.io's
next
branch and this file shows as modified without me doing anything at all.Pull request in home-assistant (if applicable): home-assistant/core#10097
Checklist: