-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Adds SABnzdb queue count #4034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds SABnzdb queue count #4034
Conversation
Thanks, @bigwoof! Pretty nice addition 👍 |
@bigwoof You have created this PR against the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissing my approval to avoid accidental merge onto the wrong branch.
I have re-based the change to the Next branch (I think) - this is my fist contribution so please bare with me. hopefully I have done things correctly. |
@bigwoof No, you've changed the target branch. Not rebased it. |
@frenck, sorry I am stumped - I am not sure how to change the base. I am a little lost if you/someone can point me in the right direction that would be great. That way I can at lease make some contributions to the documentation in the future too and I will be doing it correctly. |
adding documentation for proposed change
@bigwoof I've done it for you, in this case, I can imagine it is not an easy task. For future reference, this is what I have done: git clone https://github.com/bigwoof/home-assistant.github.io.git bigwoof
cd bigwoof
git remote add upstream [email protected]:home-assistant/home-assistant.github.io.git
git fetch upstream
git checkout next
git pull upstream next
git checkout patch-4
git rebase --onto next patch-4~1
git push -f Basically, what this does, taking your last commit and placing it on top of the latest version of the P.s. for future contributions, please be sure to branch off the right branch. For new features (like this one), use |
OK I see now - my problem was that I simply used the github web UI to make the documentation edits and I don't know if there is a way to set the base there - I think it only applies to current. If I was to keep doing this via the browser when I make changes I assume that it will only work for edits on the current branch - eg. helping with adding documentation for existing features. |
adding documentation for proposed change
Description:
Adding documentation for sensor to show number of items in SABnzdb queue
Pull request in home-assistant (if applicable): home-assistant/home-assistant#
Checklist:
current
. New documentation for platforms/components and features should go tonext
.