Documentation for squeezebox binary alarm sensors #41337
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: c0ffeeca7 <[email protected]>
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
21 tasks
There was a problem hiding this comment.
Pull Request Overview
Add documentation for new Squeezebox alarm-related binary sensors and update Velux integration docs to include the select platform.
- Add three Squeezebox binary sensors: Alarm upcoming, Alarm active, and Alarm snoozed.
- Update Velux integration to list the select platform and briefly describe its purpose.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| source/_integrations/squeezebox.markdown | Adds three new binary sensors with descriptions under the entities section. |
| source/_integrations/velux.markdown | Adds select to supported platforms and mentions it in the device types list. |
| - **Description**: The Squeezebox player has an alarm scheduled within the next 24 hours. | ||
|
|
||
| - **Alarm active** | ||
| - **Description**: One of the alarms on the Squeezebox player is currently active (means alarm currently going off). |
There was a problem hiding this comment.
The sentence is awkward and uses informal phrasing in parentheses. Consider a clearer, direct wording.
Suggested change
| - **Description**: One of the alarms on the Squeezebox player is currently active (means alarm currently going off). | |
| - **Description**: One of the alarms on the Squeezebox player is currently going off. |
| - **Description**: One of the alarms on the Squeezebox player is currently active (means alarm currently going off). | ||
|
|
||
| - **Alarm snoozed** | ||
| - **Description**: One of the alarms on the Squeezebox player is currently active but snoozing (in this case the "Alarm active" binary sensor will be in state OFF). |
There was a problem hiding this comment.
Improve grammar and clarity by removing the parenthetical and tightening the phrasing.
Suggested change
| - **Description**: One of the alarms on the Squeezebox player is currently active but snoozing (in this case the "Alarm active" binary sensor will be in state OFF). | |
| - **Description**: One of the alarms on the Squeezebox player is currently active but snoozing. In this case, the "Alarm active" binary sensor will be OFF. |
| - Cover | ||
| - Light | ||
| - Scene | ||
| - Select (set velocity for opening and closing covers) |
There was a problem hiding this comment.
Capitalize the first word inside the parentheses to match sentence-style capitalization.
Suggested change
| - Select (set velocity for opening and closing covers) | |
| - Select (Set velocity for opening and closing covers) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add documentation for alarm related binary sensors for squeezebox players.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.