Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added "Waze travel time" sensor documentation #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 31, 2018
Merged

Added "Waze travel time" sensor documentation #4498

merged 7 commits into from
Mar 31, 2018

Conversation

Myrddyn1
Copy link

Description:
Documentation for Waze Travel Time sensor.

Pull request in home-assistant: home-assistant/core#11870

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @Myrddyn1.
I've reviewed it and left some comments, could you please take a look? 👍

.rake_tasks~ Outdated
@@ -0,0 +1,19 @@
clean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the file

logo: waze.png
ha_category: Transport
ha_iot_class: "Cloud Polling"
ha_release: 0.61
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.61 is already shipped some time ago. Please set it to 0.63

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

- route
```

Configuration variables:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the configuration tags, for more information please see:
https://home-assistant.io/developers/documentation/create_page/#configuration

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the requested changes using the new tags

- **destination** (*Required*): Enter the destination address or the GPS coordinates of the location (GPS coordinates has to be separated by a comma).
- **region** (*Required*): Choose one of the available regions from 'EU', 'US', 'NA' (equivalent to 'US'), 'IL'. Default value is 'US'.
- **outputs** (*Required*): At least one output type (see below) is required.
- *duration*: The sensor will display the duration of the best chosen route, in min.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • best chosen -> best-chosen

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected

- **region** (*Required*): Choose one of the available regions from 'EU', 'US', 'NA' (equivalent to 'US'), 'IL'. Default value is 'US'.
- **outputs** (*Required*): At least one output type (see below) is required.
- *duration*: The sensor will display the duration of the best chosen route, in min.
- *distance*: The sensor will display the distance of the best chosen route, in km.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • best chosen -> best-chosen

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected

- **outputs** (*Required*): At least one output type (see below) is required.
- *duration*: The sensor will display the duration of the best chosen route, in min.
- *distance*: The sensor will display the distance of the best chosen route, in km.
- *route*: The sensor will display the main steps of the best chosen route.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • best chosen -> best-chosen

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected

logo: waze.png
ha_category: Transport
ha_iot_class: "Cloud Polling"
ha_release: 0.63
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.63 has been release some time ago. Please set it to the next version.

@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label Mar 13, 2018
@frenck frenck self-assigned this Mar 23, 2018
@frenck
Copy link
Member

frenck commented Mar 23, 2018

Rebased the PR in order to fix the build

frenck
frenck previously approved these changes Mar 23, 2018
@frenck
Copy link
Member

frenck commented Mar 23, 2018

Thanks, @Myrddyn1! 🎖

Can be merged as soon as the parent PR gets merged.

@frenck frenck removed their assignment Mar 23, 2018
@fabaff fabaff merged commit e0540d2 into home-assistant:next Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants