Add max_volume option to Onkyo media player #5153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
frenck
requested changes
Apr 14, 2018
| @@ -24,6 +24,7 @@ media_player: | |||
| - platform: onkyo | |||
| host: 192.168.1.2 | |||
| name: receiver | |||
| max_volume: 50 | |||
There was a problem hiding this comment.
We try to keep all configuration samples minimal. Thus, no optional requirement in the default sample. This helps a user to get started quickly by copy-&-paste the sample without worrying about optional parameters which they most likely not need. If required, insert a full configuration sample later that covers special setups or alike.
|
Thanks for the contribution @relvacode! |
…ocumentation to include required volume range
|
@frenck Requested change made, I also updated the documentation for |
balloob
previously approved these changes
May 5, 2018
balloob
approved these changes
May 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a new
max_volumeoption to Onkyo media playersPull request in home-assistant (if applicable): home-assistant/core#13822
Checklist:
current. New documentation for platforms/components and features should go tonext.