Thanks to visit codestin.com
Credit goes to github.com

Skip to content

New component tplink_lte with SMS notify service #6485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 11, 2018

Conversation

andtos90
Copy link
Contributor

@andtos90 andtos90 commented Oct 3, 2018

Description:

Pull request in home-assistant (if applicable): home-assistant/core#17111

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follow the standards.

@ghost ghost assigned frenck Oct 3, 2018
@ghost ghost added ready-for-review This PR needs to be reviewed and removed to-do labels Oct 3, 2018
@frenck frenck added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! new-integration This PR adds documentation for a new Home Assistant integration awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Oct 3, 2018
frenck
frenck previously approved these changes Oct 3, 2018
@frenck
Copy link
Member

frenck commented Oct 3, 2018

Thanks, @andtos90!

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck removed the ready-for-review This PR needs to be reviewed label Oct 3, 2018
@frenck frenck removed their assignment Oct 3, 2018
tjorim
tjorim previously approved these changes Oct 17, 2018
Copy link
Contributor

@tjorim tjorim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

⚠️ The ha_release will need an update before merging this one in.

@andtos90 andtos90 changed the title New component tplink_lte with SMS notify service [WIP]New component tplink_lte with SMS notify service Nov 2, 2018
@andtos90 andtos90 changed the title [WIP]New component tplink_lte with SMS notify service [WIP] New component tplink_lte with SMS notify service Nov 2, 2018
@andtos90 andtos90 dismissed stale reviews from tjorim and frenck via 43b34ca November 4, 2018 11:30
@andtos90 andtos90 changed the title [WIP] New component tplink_lte with SMS notify service New component tplink_lte with SMS notify service Nov 4, 2018
footer: true
logo: tp-link.png
ha_category: Notifications
ha_release: "0.82"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.83

sharing: true
footer: true
logo: tp-link.png
ha_release: "0.82"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.83

MartinHjelmare
MartinHjelmare previously approved these changes Nov 5, 2018
@frenck frenck added the parent-merged The parent PR has been merged already label Nov 11, 2018
@ghost ghost assigned frenck Nov 11, 2018
@frenck
Copy link
Member

frenck commented Nov 11, 2018

Thanks, @andtos90!

Corrected a small typo, but can be merged as soon as the build passes.

@frenck frenck merged commit bbba17a into home-assistant:next Nov 11, 2018
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch parent-merged The parent PR has been merged already
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants