Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Some service-row fields are now optional #7201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2018
Merged

Some service-row fields are now optional #7201

merged 3 commits into from
Nov 11, 2018

Conversation

iantrich
Copy link
Member

home-assistant/frontend#1894

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost assigned iantrich Oct 28, 2018
@ghost ghost added the ready-for-review This PR needs to be reviewed label Oct 28, 2018
@frenck frenck added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels Oct 29, 2018
@frenck frenck changed the base branch from current to next October 29, 2018 11:33
@frenck frenck added the next This PR goes into the next branch label Oct 29, 2018
frenck
frenck previously approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ @iantrich Please note, this is the second PR I needed the change the target to next. Be sure to select the correct base & target branches.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Oct 29, 2018
@iantrich iantrich changed the title service-data now optional Some service-row fields are now optional Oct 29, 2018
@iantrich
additional fields made optional
0f6f0cf 
`icon` and `action_name` will be optional as well
klaasnicolaas
klaasnicolaas requested changes Nov 6, 2018
View reviewed changes
@frenck frenck added the parent-merged The parent PR has been merged already label Nov 11, 2018
@ghost ghost assigned frenck Nov 11, 2018
@frenck frenck added current This PR goes into the current branch and removed next This PR goes into the next branch labels Nov 11, 2018
@frenck
Copy link
Member

frenck commented Nov 11, 2018

Changed target to current, since the parent PR is already released.

@frenck frenck merged commit 618132c into next Nov 11, 2018
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Nov 11, 2018
@frenck frenck deleted the iantrich-patch-2 branch November 11, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaasnicolaas klaasnicolaas klaasnicolaas requested changes

@frenck frenck frenck approved these changes

Assignees

@frenck frenck

@iantrich iantrich

Labels
current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration parent-merged The parent PR has been merged already
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iantrich @frenck @klaasnicolaas