Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add docs for 17track.net sensor platform #7303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2018
Merged

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Oct 31, 2018

Description:
This PR adds docs for the forthcoming 17track.net sensor platform.

Pull request in home-assistant (if applicable): home-assistant/core#18038

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@bachya bachya self-assigned this Oct 31, 2018
@ghost ghost added the ready-for-review This PR needs to be reviewed label Oct 31, 2018
@frenck frenck added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch has-parent This PR has a parent PR in a other repo labels Nov 1, 2018

## {% linkable_title Configuration %}

To enable the platform, add the following lines to your `configuration.yaml`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is manual configuration.yaml the only option?
Not via a configuration entry in the UI like before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The UI method was originally introduced so that users could add individual packages without needing to update configuration.yaml. Unfortunately, the method for tracking individual packages via 17track.net has been altered; until I figure out the mechanism, the underlying library (py17track) only allows account-driven package tracking.

Given that this use case is off the table, for now, there is one primary thing I review when considering whether UI config is appropriate: can the integration justify being a full-blown component (beyond the UI config use case)? Tactically:

  1. Does the integration produce more than one platform (sensor, binary_sensor, etc.)?
  2. Does the integration need to provide services?

If the answer is no, then I leave the integration as a platform (in this case, as a sensor platform). At some point, the HASS core will have a way for existing platforms to implement UI config without needing to transition to a full-blown component; when that occurs, I'll definitely take another look.

Hope that makes sense.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for explaining your decision!

ghost
ghost previously approved these changes Nov 2, 2018
@frenck frenck added the parent-merged The parent PR has been merged already label Nov 11, 2018
frenck
frenck previously approved these changes Nov 11, 2018
@frenck frenck dismissed stale reviews from ghost and themself via 31235cf November 11, 2018 13:01
@ghost ghost assigned frenck Nov 11, 2018
@frenck
Copy link
Member

frenck commented Nov 11, 2018

Thanks, @bachya!

Upped ⬆️ ha_release. Can be merged as soon as the build passes.

@frenck frenck merged commit 187e2f5 into home-assistant:next Nov 11, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Nov 11, 2018
@bachya bachya deleted the 17track branch December 3, 2018 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch parent-merged The parent PR has been merged already
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants