update LockTargetState to match LockCurrentState during lock refresh #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this @ryanpesek! |
donavanbecker
added a commit
that referenced
this pull request
Jan 23, 2025
…144) ## ♻️ Current situation The LockTargetState attribute is not updated while polling/listening to events from the August API. This leads to any manual changes of the lock (ie I physically lock/unlock it) to cause the lock status to always show unlocking or locking in Homekit. ## 💡 Proposed solution Update the LockTargetState attribute to be the same value as the LockCurrentState during both polling or pushed events. This plugin used to operate with this logic around the 2.0.0 version and prior but somewhere after 2.0.0 this logic was changed. ## ⚙️ Release Notes LockTargetState is updated for manual lock events ## ➕ Additional Information ### Testing ### Reviewer Nudging Co-authored-by: Donavan Becker <[email protected]>
donavanbecker
added a commit
that referenced
this pull request
Jan 25, 2025
- Update LockTargetState to match LockCurrentState during lock refresh. Thanks [@ryanpesek](https://github.com/ryanpesek), [#144](#144) - Fix so battery must be between 0 and 100 - Housekeeping and updated dependencies. **Full Changelog**: v3.0.0...v3.0.1
donavanbecker
added a commit
that referenced
this pull request
Jan 25, 2025
…144) ## ♻️ Current situation The LockTargetState attribute is not updated while polling/listening to events from the August API. This leads to any manual changes of the lock (ie I physically lock/unlock it) to cause the lock status to always show unlocking or locking in Homekit. ## 💡 Proposed solution Update the LockTargetState attribute to be the same value as the LockCurrentState during both polling or pushed events. This plugin used to operate with this logic around the 2.0.0 version and prior but somewhere after 2.0.0 this logic was changed. ## ⚙️ Release Notes LockTargetState is updated for manual lock events ## ➕ Additional Information ### Testing ### Reviewer Nudging Co-authored-by: Donavan Becker <[email protected]>
Merged
donavanbecker
added a commit
that referenced
this pull request
Jan 25, 2025
- Update LockTargetState to match LockCurrentState during lock refresh. Thanks [@ryanpesek](https://github.com/ryanpesek), [#144](#144) - Fix so battery must be between 0 and 100 - Housekeeping and updated dependencies. **Full Changelog**: v3.0.0...v3.0.1
donavanbecker
added a commit
that referenced
this pull request
Jan 25, 2025
…144) ## ♻️ Current situation The LockTargetState attribute is not updated while polling/listening to events from the August API. This leads to any manual changes of the lock (ie I physically lock/unlock it) to cause the lock status to always show unlocking or locking in Homekit. ## 💡 Proposed solution Update the LockTargetState attribute to be the same value as the LockCurrentState during both polling or pushed events. This plugin used to operate with this logic around the 2.0.0 version and prior but somewhere after 2.0.0 this logic was changed. ## ⚙️ Release Notes LockTargetState is updated for manual lock events ## ➕ Additional Information ### Testing ### Reviewer Nudging Co-authored-by: Donavan Becker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
The LockTargetState attribute is not updated while polling/listening to events from the August API. This leads to any manual changes of the lock (ie I physically lock/unlock it) to cause the lock status to always show unlocking or locking in Homekit.
💡 Proposed solution
Update the LockTargetState attribute to be the same value as the LockCurrentState during both polling or pushed events. This plugin used to operate with this logic around the 2.0.0 version and prior but somewhere after 2.0.0 this logic was changed.
⚙️ Release Notes
LockTargetState is updated for manual lock events
➕ Additional Information
Testing
Reviewer Nudging