Fix "Cannot set properties of undefined" error in validated() method when credentials are missing #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical issue where the plugin would crash with
Cannot set properties of undefined (setting 'installId')
when the homebridge config file didn't have a properly initializedcredentials
object for the August platform.Problem
The error occurred in the
validated()
method when trying to set properties onpluginConfig.credentials
:This happened because:
credentials
was completely missing from the config file, it would beundefined
credentials
was explicitly set tonull
, the existing checktypeof pluginConfig.credentials !== 'object'
would pass (sincetypeof null === 'object'
in JavaScript), but then trying to set properties onnull
would failSolution
Updated the
pluginConfig()
method to properly handle bothnull
andundefined
credentials:Now when the
validated()
method runs, it can safely set properties onpluginConfig.credentials
because the object is guaranteed to exist.Testing
Added comprehensive tests to verify:
All existing tests continue to pass, ensuring no regressions.
Fixes #169.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.