Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(deps): remove "request" package #329

Merged
azu merged 3 commits into
masterfrom
328-remove-request-package
Mar 26, 2023
Merged

fix(deps): remove "request" package #329
azu merged 3 commits into
masterfrom
328-remove-request-package

Conversation

@azu

@azu azu commented Mar 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@azu azu linked an issue Mar 26, 2023 that may be closed by this pull request
Remove "request" package #328
Closed
@azu azu added the Type: Security Vulnerability disclosure or Fixing security issue label Mar 26, 2023
azu
azu commented Mar 26, 2023
View reviewed changes
Comment thread packages/honkit/src/utils/fs.ts
// create dest dir if not exists
const destDir = path.dirname(destFilePath);
await fs.promises.mkdir(destDir, { recursive: true });
const d = Promise.defer();

@azu azu Mar 26, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to use native Promise

@azu azu merged commit 82ba754 into master Mar 26, 2023
@azu azu deleted the 328-remove-request-package branch March 26, 2023 06:31
@Phin-Kurniawan

Phin-Kurniawan commented Apr 3, 2023

Copy link
Copy Markdown

so how to fix this issue
=== npm audit security report ===

                             Manual Review
         Some vulnerabilities require your attention to resolve

      Visit https://go.npm.me/audit-guide for additional guidance

Moderate Server-Side Request Forgery in Request

Package request

Patched in No patch available

Dependency of firebase-tools

Path firebase-tools > request

More info GHSA-p8p7-x288-28g6

Moderate Server-Side Request Forgery in Request

Package request

Patched in No patch available

Dependency of request

Path request

More info GHSA-p8p7-x288-28g6

found 2 moderate severity vulnerabilities in 869 scanned packages
2 vulnerabilities require manual review. See the full report for details.

@azu

azu commented Apr 3, 2023

Copy link
Copy Markdown
Member Author

Dependency of firebase-tools

Path firebase-tools > request

Your dependendcies has firebase-tools that use request.
It is not related to HonKit

@honkit honkit locked as resolved and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Type: Security Vulnerability disclosure or Fixing security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove "request" package

2 participants

@azu @Phin-Kurniawan