Symfony 5#29
Merged
Merged
Conversation
- PHPUnit namespaces - Tests mocks as FormFactoryInterface requires a type
23c69f8 to
47e0f11
Compare
Member
|
Thanks for the PR! I will have a look at it as soon as I have some time. |
mvannes
approved these changes
Mar 6, 2020
mvannes
left a comment
Contributor
There was a problem hiding this comment.
Hey, really sorry about this incredible delay. There's some small conflicts now due to us responding to our own pull requests but somehow not yours.
Very sorry about that again, as this looks great!
It's got my approval if the conflicts are fixed
47e0f11 to
55fe584
Compare
Contributor
Author
|
Rebased and passing test locally. 👍 |
Contributor
|
Great, I'll look at it again Monday, and I'll assume it's fine and merge and tag then! Thank you for your help! |
yannickl88
approved these changes
Mar 6, 2020
yannickl88
left a comment
Member
There was a problem hiding this comment.
yes, apologies for the delay. I will merge this now. Thanks for contributing!
Member
|
I've created v1.7.0 to include these changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a bit of time, and November is fast approaching. 🎉
^5.0Updated PHPUnit constraint to include^7.5Notes:
symfony/debugis being removed/replaced in Symfony 5, but forward compat. comes in 4.4For local testing:
Let me know if you want anything more.