Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sfnelson
Copy link

Failing test for #580

When rendering a turbo-frame with data-turbo-action="advance" to
promote visits, Turbo checks the head of the current document against
the head of the incoming response to decide whether to 'render' the
synthetic navigation.

In the turbo tests, this check passes because the head of the frame
response matches the page response, but in a frame response generated
by turbo-rails, the head is empty and so the check fails.

This behaviour changed in Turbo 8/Turbo Rails 2, and as a consequence
frame navigation visits are no longer compatible with history
restorations, as demonstrated by the included test.
@seanpdoyle
Copy link
Contributor

@jorgemanrubia could you approve this PR so that CI could execute?

@seanpdoyle
Copy link
Contributor

@jorgemanrubia I'm sorry for being unclear. I meant "approve" in the CI sense, to address the "1 workflow awaiting approval" message.

@jorgemanrubia
Copy link
Member

Oh sorry @seanpdoyle 🙏, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants