Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support the <wbr> element #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 2, 2023
Merged

Support the <wbr> element #395

merged 5 commits into from
Mar 2, 2023

Conversation

twm
Copy link
Contributor

@twm twm commented Jun 10, 2018 •
edited by ambv
Loading

<wbr> is an empty element which indicates a line break opportunity. The effect is similar to inserting a zero-width space, but superior because <wbr> does not affect the text of the selection (so when copied there aren't invisible characters in it).

<wbr> is safe when sanitizing HTML.

Partially addresses #203.

https://html.spec.whatwg.org/#the-wbr-element

@codecov-io
Copy link

codecov-io commented Jun 10, 2018 •
edited
Loading

Codecov Report

Merging #395 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   90.79%   90.79%   +<.01%     
==========================================
  Files          50       50              
  Lines        6952     6956       +4     
  Branches     1328     1328              
==========================================
+ Hits         6312     6316       +4     
  Misses        481      481              
  Partials      159      159
Impacted Files Coverage Δ
html5lib/filters/sanitizer.py 93.16% <ø> (ø) ⬆️
html5lib/constants.py 100% <ø> (ø) ⬆️
html5lib/tests/test_sanitizer.py 94.87% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f92357...f3c8eb3. Read the comment docs.

@twm twm mentioned this pull request Jun 10, 2018
Closed
twm added a commit to twm/html5lib-python that referenced this pull request Jun 10, 2018
@twm
Remove Appveyor Python 3.3 builds
e137495 
It looks like this was missed in html5lib#358. It is causing build failures in html5lib#395 and html5lib#396.
@twm twm mentioned this pull request Jun 10, 2018
Merged
gsnedders pushed a commit that referenced this pull request Oct 1, 2018
@twm @gsnedders
Remove Appveyor Python 3.3 builds (#397)
7facf98 
It looks like this was missed in #358. It is causing build failures in #395 and #396.
@twm
Copy link
Contributor Author

twm commented Nov 5, 2018

@gsnedders Is there anything blocking merge of this or #396 on my end?

twm added a commit to twm/yarrharr that referenced this pull request Jul 20, 2019
@twm
Monkey patch so <wbr> serializes properly
1d97360 
A proper fix is at html5lib/html5lib-python#395
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2020 •
edited
Loading

Codecov Report

Merging #395 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files          50       50           
  Lines        7044     7048    +4     
  Branches     1341     1341           
=======================================
+ Hits         6415     6419    +4     
  Misses        475      475           
  Partials      154      154
Impacted Files Coverage Δ
html5lib/constants.py 100.00% <ø> (ø)
html5lib/filters/sanitizer.py 93.38% <ø> (ø)
html5lib/tests/test_sanitizer.py 95.06% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4646e6...08966bb. Read the comment docs.

@twm twm mentioned this pull request Jul 3, 2020
Merged
@g-k g-k mentioned this pull request Sep 16, 2020
Open
@jayaddison jayaddison mentioned this pull request Jan 10, 2021
Closed
@ambv ambv merged commit 6ca0244 into html5lib:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sanitizer serializer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@twm @codecov-io @codecov-commenter @ambv @gsnedders