fix(tag-pair): point tag-pair error message to correct line and colum… #1503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedaviddias
approved these changes
Apr 28, 2025
Open
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1503 +/- ##
==========================================
- Coverage 97.97% 96.99% -0.99%
==========================================
Files 2 2
Lines 1627 1628 +1
Branches 339 334 -5
==========================================
- Hits 1594 1579 -15
- Misses 33 49 +16
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@bebehr - thanks for this PR and sorry it took a little while to get merged. If you could kindly make a separate PR to fix the Codecov issue that'd be much appreciated! In the meantime, I'll get this merged as it was approved by @thedaviddias :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n number
fix #1284
Short description of what this resolves:
Pointing to correct line number in tag-pair message when end tag is missing.
Proposed changes:
Adds lastEvent.line and lastEvent.col to rule check with updated tests.