Rule: Add form-method-require rule
#1710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Deploying htmlhint with
|
| Latest commit: |
6077eb1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://27a2ca79.htmlhint.pages.dev |
| Branch Preview URL: | https://dev-coliff-add-form-method-r.htmlhint.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new HTMLHint linting rule form-method-require that enforces all <form> elements to have a valid method attribute. The rule improves form security by preventing sensitive data exposure through default GET methods.
Key changes:
- Implements a new rule to validate form method attributes with accepted values "get", "post", or "dialog"
- Integrates the rule into the core HTMLHint system with proper type definitions and exports
- Provides comprehensive test coverage and user documentation
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/core/rules/form-method-require.ts | Core rule implementation checking for method attribute presence and validity |
| src/core/rules/index.ts | Exports the new rule for integration into the rule system |
| src/core/types.ts | Adds rule configuration option to the Ruleset interface |
| test/rules/form-method-require.spec.js | Comprehensive test suite covering valid/invalid scenarios |
| website/src/content/docs/rules/form-method-require.mdx | User documentation with examples and rationale |
| .editorconfig | Minor formatting cleanup removing blank lines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new linting rule to enforce that all
<form>elements have amethodattribute with a valid value ("get", "post", or "dialog"). The rule is integrated into the core ruleset, tested with various scenarios, and documented for users.New rule: Require valid
methodattribute on<form>elementsform-method-require.tsto check for the presence and validity of themethodattribute on<form>elements.index.ts) and updated the ruleset interface (types.ts) to support configuration. [1] [2]Testing and documentation
form-method-require.spec.js.form-method-require.mdx. (page hidden for now)Other changes
.editorconfigfor consistency.