Thanks to visit codestin.com
Credit goes to github.com

Skip to content

added prettier with husky #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Shinigami92 wants to merge 2 commits into from
Closed

added prettier with husky #255

Shinigami92 wants to merge 2 commits into from

Conversation

@Shinigami92
Copy link
Contributor

@Shinigami92 Shinigami92 commented Aug 22, 2018

  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Short description of what this resolves:

The whole code is pretty formatted
This happens when a contributor commits a file
husky will register an precommit event and perform pretty-quick, which will format the submitted files with prettier and print a helpful message to the console/terminal

I oriented myself to https://github.com/palantir/tslint/pull/4012/files

Used tools:

Proposed changes:

  • Formatting with prettier at commit

@thedaviddias thedaviddias self-requested a review August 23, 2018 01:12
@thedaviddias thedaviddias added enhancement Functionality that enhances existing features #status: dev in progress labels Aug 23, 2018
@Shinigami92 Shinigami92 mentioned this pull request Aug 23, 2018
Closed
17 tasks
@codecov-io
Copy link

codecov-io commented Aug 23, 2018 •
edited
Loading

Codecov Report

Merging #255 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #255   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           1      1           
=====================================
  Hits            1      1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24fb1cd...4dfc0ea. Read the comment docs.

@Shinigami92
Copy link
Contributor Author

Shinigami92 commented Aug 24, 2018

The configuration of

{
    "printWidth": 100,
    "singleQuote": true
}

is arguable.

printWidth 100 because on a 1080p monitor in the GitHub Web GUI you have no wraps in the side by side view
singleQuote true because the current style (and also my preference) uses this

but we can choose a complete other config if you want

@thedaviddias thedaviddias changed the base branch from master to develop August 27, 2018 17:41
@thedaviddias thedaviddias mentioned this pull request Sep 3, 2018
Merged
2 tasks
@thedaviddias
Copy link
Member

thedaviddias commented Sep 3, 2018

Solved with #287

@Shinigami92 Shinigami92 deleted the prettier branch May 17, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thedaviddias thedaviddias Awaiting requested review from thedaviddias

Assignees

No one assigned

Labels

enhancement Functionality that enhances existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Shinigami92 @codecov-io @thedaviddias