Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Shinigami92
Copy link
Contributor

Short description of what this resolves:

Currently there is a bug in nodejs which affects macos
nodejs/node#19218

To get around this, some tests need to be compared to a file that generates fewer hint errors

Proposed changes:

Test against a file with less hints

@Shinigami92 Shinigami92 requested a review from thedaviddias June 1, 2020 19:30
@Shinigami92 Shinigami92 self-assigned this Jun 1, 2020
Copy link
Member

@thedaviddias thedaviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@Shinigami92 Shinigami92 merged commit d6e5861 into master Jun 1, 2020
@Shinigami92 Shinigami92 deleted the test/shrink-down-test-file branch June 1, 2020 20:18
@thedaviddias
Copy link
Member

πŸŽ‰ This PR is included in version 0.15.0-beta.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@thedaviddias
Copy link
Member

πŸŽ‰ This PR is included in version 0.14.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants