Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(build): upgrade package-lock version for latest NPM #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thedaviddias merged 1 commit into from
Nov 24, 2021
Merged

chore(build): upgrade package-lock version for latest NPM #722

thedaviddias merged 1 commit into from
Nov 24, 2021

Conversation

@nschonni
Copy link
Contributor

@nschonni nschonni commented Nov 23, 2021

Short description of what this resolves:
Now that Node 16 is the LTS release, it ships with NPM 8, which will now try to upgrade the lockfile when touched. This should be backward compatible with NPM clients on older Node versions

Proposed changes:

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 23, 2021
@nschonni nschonni force-pushed the package-lock-upgrade branch from c7acdd1 to bba5af4 Compare November 23, 2021 19:11
@diegocr
Copy link

diegocr commented Nov 23, 2021 •
edited
Loading

@nschonni dupe of #695 (?)

Btw, it will be quite appreciated if you guys (i.e. anyone with package release permission) can look into #664 :-)

@nschonni
Copy link
Contributor Author

nschonni commented Nov 23, 2021

@nschonni dupe of #695 (?)

#719 covered part of that, but I'm not sure if the rest of the package-lock.json changes were also any other fixups or just a plain upgrade like this one.

Btw, it will be quite appreciated if you guys (i.e. anyone with package release permission) can look into #664 :-)

There is no patched version of parse-glob and it isn't maintained, so the only way to address that is by changing the library

@nschonni
Copy link
Contributor Author

nschonni commented Nov 23, 2021

@thedaviddias let me know when your done landing the dependabot updates, then I'll rebase this one

@thedaviddias
Copy link
Member

thedaviddias commented Nov 23, 2021

@thedaviddias let me know when your done landing the dependabot updates, then I'll rebase this one

I'm done for now, go ahead with your rebase, I will wait to update the deps. Thanks for the work!

@nschonni nschonni force-pushed the package-lock-upgrade branch from bba5af4 to 7f6d3f4 Compare November 23, 2021 23:58
@nschonni
Copy link
Contributor Author

nschonni commented Nov 24, 2021

@thedaviddias rebased

@thedaviddias thedaviddias merged commit 2a335ce into htmlhint:master Nov 24, 2021
@nschonni nschonni deleted the package-lock-upgrade branch November 24, 2021 00:08
@thedaviddias
Copy link
Member

thedaviddias commented Nov 24, 2021

🎉 This PR is included in version 0.16.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thedaviddias thedaviddias thedaviddias approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nschonni @diegocr @thedaviddias