Clamp buffer length at INT_MAX in xSnprintf #1770
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
xSnprintf
more robust against large input buffer sizes. There is an API defect in the snprintf() function, of which the return type is signedint
and notsize_t
. If the specified input buffer length is> INT_MAX
, the behavior is undefined in standard C. (In POSIX, the function would fail witherrno = EOVERFLOW
.) Rather than let the caller ensure the buffer length is<= INT_MAX
, it's better to let xSnprintf() clamp the buffer length.