Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Replace redundant ObjectMapper objects with JsonUtil #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2019
Merged

Replace redundant ObjectMapper objects with JsonUtil #41

merged 1 commit into from
Mar 22, 2019

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Mar 20, 2019

Change-Id: I152e528b13fcacfd543141b372999e74586c02ce

@codecov
Copy link

codecov bot commented Mar 20, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@892325d). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #41   +/-   ##
=========================================
  Coverage          ?   73.79%           
  Complexity        ?      460           
=========================================
  Files             ?       89           
  Lines             ?     1977           
  Branches          ?      106           
=========================================
  Hits              ?     1459           
  Misses            ?      432           
  Partials          ?       86
Impacted Files Coverage Δ Complexity Δ
...m/baidu/hugegraph/serializer/PathDeserializer.java 78.78% <100%> (ø) 9 <0> (?)
...m/baidu/hugegraph/structure/gremlin/ResultSet.java 67.56% <100%> (ø) 10 <1> (?)
...n/java/com/baidu/hugegraph/api/graph/GraphAPI.java 94.11% <100%> (ø) 10 <0> (?)
...c/main/java/com/baidu/hugegraph/util/JsonUtil.java 30.76% <36.36%> (ø) 4 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 892325d...1971e45. Read the comment docs.

javeme
javeme previously requested changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improve commit message with specific title

@Linary Linary changed the title A little modification Replace redundant ObjectMapper objects with JsonUtil Mar 20, 2019
@Linary
Replace redundant ObjectMapper objects with JsonUtil
1971e45 
Change-Id: I152e528b13fcacfd543141b372999e74586c02ce
@javeme javeme merged commit 2c31790 into master Mar 22, 2019
@javeme javeme deleted the little-modify branch March 22, 2019 09:36
zhoney pushed a commit to zhoney/hugegraph-client that referenced this pull request Sep 19, 2019
@Linary @zhoney
Replace redundant ObjectMapper objects with JsonUtil (hugegraph#41)
7c399e4 
Change-Id: I152e528b13fcacfd543141b372999e74586c02ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javeme javeme javeme approved these changes

+1 more reviewer

@zhoney zhoney zhoney approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Linary @javeme @zhoney