Support batch updating elements' property #46

imbajin · 2019-04-30T10:31:44Z

Need more Unit-Tests for different update strategy.

Linary · 2019-05-23T02:14:41Z

src/main/java/com/baidu/hugegraph/api/graph/EdgeAPI.java

+        MultivaluedHashMap<String, Object> headers = new MultivaluedHashMap<>();
+        headers.putSingle("Content-Encoding", BATCH_ENCODING);
+        String updateStrategies = GraphAPI.formatProperties(strategies);
+        Map<String ,Object> params = ImmutableMap.of("updateStrategies",


updateStrategies -> update_strategies

Linary · 2019-05-23T02:17:35Z

src/main/java/com/baidu/hugegraph/api/graph/EdgeAPI.java

        return ids;
    }

+    public List<Edge> update(List<Edge> edges,


Modify according to server comments

javeme · 2019-06-04T06:17:09Z

src/main/java/com/baidu/hugegraph/api/graph/VertexAPI.java

+                                                     updateStrategies,
+                                                     "createIfNotExist",
+                                                     createIfNotExist);
+        RestResult result = this.client.post(this.batchPath() + "Update",


this.client.put(this.batchPath(), ...)

javeme · 2019-06-04T06:17:40Z

src/main/java/com/baidu/hugegraph/api/graph/VertexAPI.java

        return ids;
    }

+    public List<Vertex> update(List<Vertex> vertices,


add api test cases for each strategy

Linary · 2019-07-10T03:26:38Z

src/main/java/com/baidu/hugegraph/api/graph/structure/BatchEdgeRequest.java

+
+    // TODO: Edge seems OK, should we keep the JsonEdge's code?
+    @JsonProperty("edges")
+    private List<Edge> jsonEdges;


Use Edge is enough

Linary · 2019-07-10T03:29:27Z

src/main/java/com/baidu/hugegraph/api/graph/structure/BatchEdgeRequest.java

+    }
+
+    @JsonIgnoreProperties(value = {"type"})
+    private class JsonEdge {


Linary · 2019-07-10T03:30:14Z

src/main/java/com/baidu/hugegraph/api/graph/structure/BatchEdgeRequest.java

+                            "Parameter 'update_strategies' cannot be empty");
+            // Not support createIfNotExist equals false now
+            E.checkArgument(req.createIfNotExist == true, "Parameter " +
+                            "'create_if_not_exist' is not supported now");


is not supported false now

Linary · 2019-07-10T03:30:30Z

src/main/java/com/baidu/hugegraph/api/graph/structure/BatchVertexRequest.java

+public class BatchVertexRequest {
+
+    // TODO: Vertex seems OK, should we keep the JsonVertex's code?
+    @JsonProperty("vertices")


Vertex is enough

Linary · 2019-07-10T03:32:06Z

src/main/java/com/baidu/hugegraph/api/graph/structure/BatchVertexRequest.java

+
+        public Builder() {
+            this.req = new BatchVertexRequest();
+            //this.vertexBuilders = new ArrayList<>();


seems open the comment is better

Linary · 2019-07-10T03:35:43Z

src/main/java/com/baidu/hugegraph/api/graph/structure/BatchVertexRequest.java

+        }
+
+        public BatchVertexRequest build() {
+            /*this.vertexBuilders.forEach(builder -> {


does it need?

Linary · 2019-07-10T03:37:39Z

src/main/java/com/baidu/hugegraph/api/graph/structure/UpdateStrategy.java

+package com.baidu.hugegraph.api.graph.structure;
+
+public enum UpdateStrategy {
+    SUM,


add an empty line

Linary · 2019-07-10T03:40:02Z

src/test/java/com/baidu/hugegraph/api/VertexApiTest.java

+            Object price = vertex.properties().get("price");
+            Assert.assertTrue(price instanceof Number);
+            Assert.assertTrue((int) price == 0);
+            System.out.println(vertex);


remove System.out.println(vertex)

Linary · 2019-07-10T03:40:24Z

src/test/java/com/baidu/hugegraph/api/VertexApiTest.java

+        this.graph().updateVertices(req).forEach(vertex -> {
+            Object price = vertex.properties().get("price");
+            Assert.assertTrue(price instanceof Number);
+            Assert.assertTrue((int) price == 0);


Use Assert.assertEquals

Linary · 2019-07-10T03:44:32Z

src/test/java/com/baidu/hugegraph/api/VertexApiTest.java

+
+    @Test
+    public void testBatchUpdateStrategySmaller() {
+        BatchVertexRequest req = batchVertexRequest("fullDate", -1, 1,


Don't use fullDate(Date property), it should actually be deserialized to date, now being deserialized to number is a bug

Need more Unit-Tests for different update strategy.

Change-Id: I2d6e6fba7527f18e1c5b29ace377639cb6f8f824

javeme · 2019-07-10T11:57:20Z

src/test/java/com/baidu/hugegraph/api/VertexApiTest.java

+        BatchVertexRequest req = batchVertexRequest("price", 1, -1,
+                                                    UpdateStrategy.SUM);
+
+        this.graph().updateVertices(req).forEach(vertex -> {


call vertexAPI.update in api test

javeme · 2019-07-10T13:45:49Z

src/test/java/com/baidu/hugegraph/api/VertexApiTest.java

+        this.graph().updateVertices(req).forEach(vertex -> {
+            Object price = vertex.properties().get("price");
+            Assert.assertTrue(price instanceof Number);
+            Assert.assertTrue((int) price > 0);


Assert.assertEquals(1, price);

The variable i is now appended to the test data, so the attribute of each element are not fixed values.
And due to the order of the collection is not fixed from server's response, cannot be one-to-one correspondence with index, like set-property, price-property, and others.
So shall we get rid of all the changes so that elements can have the same property values?

javeme · 2019-07-10T13:46:10Z

src/test/java/com/baidu/hugegraph/api/VertexApiTest.java

+        this.graph().updateVertices(req).forEach(vertex -> {
+            Object price = vertex.properties().get("price");
+            Assert.assertTrue(price instanceof Number);
+            Assert.assertTrue((int) price < 0);


Assert.assertEquals(-1, price);

javeme · 2019-07-10T13:47:10Z

src/test/java/com/baidu/hugegraph/api/VertexApiTest.java

+        this.graph().updateVertices(req).forEach(vertex -> {
+            Object set = vertex.properties().get("set");
+            Assert.assertTrue(set instanceof Collection);
+            Assert.assertEquals(2, ((Collection) set).size());


add Assert.assertEquals(ImmutableSet.of("xx", "xx"), set);
same as other tests

(Collection<?>) set

javeme · 2019-07-10T13:50:14Z

src/test/java/com/baidu/hugegraph/api/EdgeApiTest.java

+        graph().updateEdges(req).forEach(edge -> {
+            Object set = edge.properties().get("set");
+            Assert.assertTrue(set instanceof Collection);
+            Assert.assertTrue(((Collection)set).size() == 2);


Assert.assertTrue(((Collection<?>) set).size() == 2);

javeme · 2019-07-10T13:50:27Z

src/test/java/com/baidu/hugegraph/api/EdgeApiTest.java

+            Object set = edge.properties().get("set");
+            Assert.assertTrue(set instanceof Collection);
+            Assert.assertTrue(((Collection)set).size() == 2);
+            System.out.println(edge);


javeme · 2019-07-10T13:51:18Z

src/test/java/com/baidu/hugegraph/api/VertexApiTest.java

+        this.graph().updateVertices(req).forEach(vertex -> {
+            Object list = vertex.properties().get("list");
+            Assert.assertTrue(list instanceof List);
+            Assert.assertEquals(2, ((List) list).size());


((List<?>) list)

javeme · 2019-07-10T13:51:28Z

src/test/java/com/baidu/hugegraph/api/VertexApiTest.java

+        this.graph().updateVertices(req).forEach(vertex -> {
+            Object list = vertex.properties().get("list");
+            Assert.assertTrue(list instanceof List);
+            Assert.assertTrue(((List) list).isEmpty());


((List<?>) list)

javeme · 2019-07-10T13:51:50Z

src/test/java/com/baidu/hugegraph/api/VertexApiTest.java

+        this.graph().updateVertices(req).forEach(vertex -> {
+            Object set = vertex.properties().get("set");
+            Assert.assertTrue(set instanceof Collection);
+            Assert.assertTrue(((Collection) set).isEmpty());


(Collection<?>) set

javeme · 2019-07-10T13:52:00Z

src/test/java/com/baidu/hugegraph/api/VertexApiTest.java

+        this.graph().updateVertices(req).forEach(vertex -> {
+            Object set = vertex.properties().get("set");
+            Assert.assertTrue(set instanceof Collection);
+            Assert.assertEquals(2, ((Collection) set).size());


(Collection<?>) set

javeme · 2019-07-12T03:07:51Z

src/main/java/com/baidu/hugegraph/api/graph/EdgeAPI.java

+
+        // TODO: Consider better way to check exception & deserialized result
+        int responseCode = result.status();
+        if (responseCode != 200) {


checked by RestClient.checkStatus(), just remove this check

javeme · 2019-07-12T03:08:01Z

src/main/java/com/baidu/hugegraph/api/graph/VertexAPI.java

+
+        // TODO: Consider better way to check exception & deserialized result
+        int responseCode = result.status();
+        if (responseCode != 200) {


javeme · 2019-07-12T03:10:05Z

src/test/java/com/baidu/hugegraph/api/EdgeApiTest.java

+    public void testBatchUpdateStrategyBigger() {
+        BatchEdgeRequest req = batchEdgeRequest("price", 1, -1,
+                                                UpdateStrategy.BIGGER);
+        this.edgeAPI.update(req).forEach(edge -> {


assert response size equals to batch size

javeme · 2019-07-12T03:13:58Z

src/test/java/com/baidu/hugegraph/api/EdgeApiTest.java

+    private BatchEdgeRequest batchEdgeRequest(String key, Object oldData,
+                                              Object newData,
+                                              UpdateStrategy strategy) {
+        Map<String, UpdateStrategy> strategies = ImmutableMap.of(key, strategy);


prefer to move to line 683

javeme · 2019-07-12T03:14:38Z

src/main/java/com/baidu/hugegraph/api/graph/structure/BatchVertexRequest.java

+            return this;
+        }
+
+        public Builder updateStrategies(Map<String, UpdateStrategy> maps) {


rename method name to updatingStrategies
rename maps to map or strategies

javeme · 2019-07-12T03:16:58Z

src/main/java/com/baidu/hugegraph/api/graph/structure/BatchVertexRequest.java

+        }
+
+        public Builder updateStrategies(Map<String, UpdateStrategy> maps) {
+            this.req.updateStrategies = maps;


new Map(maps) to clone

javeme · 2019-07-12T03:18:32Z

src/main/java/com/baidu/hugegraph/api/graph/structure/BatchVertexRequest.java

+        public Builder updateStrategies(Map<String, UpdateStrategy> maps) {
+            this.req.updateStrategies = maps;
+            return this;
+        }


add method:

public Builder updateStrategy(String property, UpdateStrategy strategy) { updateStrategies.put(property, strategy); }

javeme · 2019-07-12T03:22:29Z

src/test/java/com/baidu/hugegraph/api/VertexApiTest.java

+            Assert.assertTrue(((List<?>) list).isEmpty());
+        });
+    }
+


add some negative tests

javeme · 2019-07-15T03:27:17Z

src/test/java/com/baidu/hugegraph/BaseClientTest.java

        schema.propertyKey("price").asInt().ifNotExist().create();
        schema.propertyKey("weight").asDouble().ifNotExist().create();
+        // Add for assertBatchResponse updatingStrategies & Date type
+        schema.propertyKey("fullDate").asDate().ifNotExist().create();


change propertyKey("date").asText() to propertyKey("date").asDate()

javeme · 2019-07-15T03:30:21Z

src/test/java/com/baidu/hugegraph/BaseClientTest.java

              .ifNotExist()
              .create();
+
+        schema.vertexLabel("testV")


need a specific name, it represents a scene

javeme · 2019-07-15T03:30:28Z

src/test/java/com/baidu/hugegraph/BaseClientTest.java

              .ifNotExist()
              .create();
+
+        schema.edgeLabel("testE")


javeme · 2019-07-15T03:31:37Z

src/test/java/com/baidu/hugegraph/BaseClientTest.java

              .create();
+
+        schema.vertexLabel("testV")
+              .properties("name", "set", "fullDate", "price", "list")


please keep order according to a certain rule

javeme · 2019-07-15T03:31:45Z

src/test/java/com/baidu/hugegraph/BaseClientTest.java

+        schema.vertexLabel("testV")
+              .properties("name", "set", "fullDate", "price", "list")
+              .primaryKeys("name")
+              .nullableKeys("set", "fullDate", "price", "list")


javeme · 2019-07-15T03:32:27Z

src/test/java/com/baidu/hugegraph/api/VertexApiTest.java

+        this.assertBatchResponse(vertices, "price", 5);
+    }
+
+    // TODO: Add date comparison after fixing the date serialization bug


start with /**

codecov · 2019-07-16T14:20:55Z

Codecov Report

Merging #46 into master will increase coverage by 0.09%.
The diff coverage is 78.37%.

@@             Coverage Diff              @@
##             master      #46      +/-   ##
============================================
+ Coverage     74.96%   75.06%   +0.09%     
- Complexity      502      508       +6     
============================================
  Files            91       94       +3     
  Lines          2209     2282      +73     
  Branches        137      143       +6     
============================================
+ Hits           1656     1713      +57     
- Misses          452      466      +14     
- Partials        101      103       +2

Impacted Files	Coverage Δ	Complexity Δ
...baidu/hugegraph/api/traverser/NeighborRankAPI.java	`85.29% <ø> (ø)`	`3 <0> (ø)`	⬇️
.../baidu/hugegraph/structure/schema/PropertyKey.java	`68% <ø> (ø)`	`3 <0> (ø)`	⬇️
.../java/com/baidu/hugegraph/driver/GraphManager.java	`77.27% <0%> (-3.68%)`	`52 <0> (ø)`
.../hugegraph/api/graph/structure/UpdateStrategy.java	`100% <100%> (ø)`	`1 <1> (?)`
.../main/java/com/baidu/hugegraph/util/TaskCache.java	`84.44% <100%> (ø)`	`17 <0> (ø)`	⬇️
.../java/com/baidu/hugegraph/api/graph/VertexAPI.java	`93.02% <100%> (+0.71%)`	`11 <1> (+1)`	⬆️
...in/java/com/baidu/hugegraph/api/graph/EdgeAPI.java	`93.47% <100%> (+0.62%)`	`11 <1> (+1)`	⬆️
...egraph/api/graph/structure/BatchVertexRequest.java	`79.16% <79.16%> (ø)`	`1 <1> (?)`
...ugegraph/api/graph/structure/BatchEdgeRequest.java	`81.48% <81.48%> (ø)`	`1 <1> (?)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c6fb43...e807719. Read the comment docs.

javeme · 2019-07-17T03:45:04Z

src/test/java/com/baidu/hugegraph/BaseClientTest.java

+              .primaryKeys("name")
+              .nullableKeys("price", "date", "set", "list")
+              .ifNotExist()
+              .create();


move to BatchUpdateElementApiTest

javeme · 2019-07-17T03:45:14Z

src/test/java/com/baidu/hugegraph/BaseClientTest.java

+              .properties("name", "price", "date", "set", "list")
+              .nullableKeys("name", "price", "date", "set", "list")
+              .ifNotExist()
+              .create();


move to BatchUpdateElementApiTest

javeme · 2019-07-17T03:45:26Z

src/test/java/com/baidu/hugegraph/BaseClientTest.java

+                                                     data[1] + index), value);
+            }
+        });
+    }


move to BatchUpdateElementApiTest

javeme · 2019-07-17T03:47:21Z

src/test/java/com/baidu/hugegraph/api/BatchUpdateElementApiTest.java

+
+public class BatchUpdateElementApiTest extends BaseApiTest {
+
+    final int number = 5;


rename to:
private static final int BATCH_SIZE = 5;

javeme · 2019-07-17T03:48:19Z

src/test/java/com/baidu/hugegraph/unit/BatchElementRequestTest.java

+    @Test
+    public void testVertexEmptyUpdateStrategy() {
+        List<Vertex> vertices = this.createNVertexBatch("object", "new", 5);
+        Map<String, UpdateStrategy> strategies = Collections.emptyMap();


ImmutableMap.of()

javeme · 2019-07-17T03:48:39Z

src/test/java/com/baidu/hugegraph/unit/BatchElementRequestTest.java

+
+    @Test
+    public void testVertexEmptyUpdateStrategy() {
+        List<Vertex> vertices = this.createNVertexBatch("object", "new", 5);


mock instead

javeme · 2019-07-17T03:52:19Z

src/test/java/com/baidu/hugegraph/unit/BatchElementRequestTest.java

+        edge.sourceLabel("object");
+        edge.targetId("object:2");
+        edge.targetLabel("object");
+        edge.property("price", 1);


If these code does not affect the test logic, we can add a method createEdge()

javeme · 2019-07-17T03:56:57Z

src/test/java/com/baidu/hugegraph/api/BatchUpdateElementApiTest.java

+        req = batchVertexRequest("list", "old", "x", UpdateStrategy.ELIMINATE);
+        vertices = this.vertexAPI.update(req);
+        this.assertBatchResponse(vertices, "list", "old");
+    }


add negative test like updateStrategies is null or empty:

Whitebox.setInternalState(req, "updateStrategies", empty); this.vertexAPI.update(req); // expect exception

javeme · 2019-07-17T03:57:37Z

src/test/java/com/baidu/hugegraph/unit/BatchElementRequestTest.java

+                                            .createIfNotExist(true)
+                                            .build();
+        });
+    }


add a test that build ok

javeme · 2019-07-17T11:16:01Z

src/test/java/com/baidu/hugegraph/api/BatchUpdateElementApiTest.java

        return req;
    }
+
+    private void assertBatchResponse(List<? extends GraphElement> elements,


javeme · 2019-07-17T11:16:05Z

src/test/java/com/baidu/hugegraph/api/BatchUpdateElementApiTest.java

+        });
+    }
+
+    private void assertBatchResponse(List<? extends GraphElement> elements,


javeme · 2019-07-17T11:17:19Z

src/test/java/com/baidu/hugegraph/unit/BatchElementRequestTest.java

+        Assert.assertEquals(true, created);
+    }
+
+    private Vertex createVertex() {


javeme · 2019-07-17T11:17:23Z

src/test/java/com/baidu/hugegraph/unit/BatchElementRequestTest.java

+        return vertex;
+    }
+
+    private Edge createEdge() {


javeme · 2019-07-17T11:18:21Z

src/test/java/com/baidu/hugegraph/unit/BatchElementRequestTest.java

 import com.google.common.collect.ImmutableMap;

-public class BatchElementRequestTest extends BaseClientTest {
+public class BatchElementRequestTest {


extends BaseUnitTest
and add it to UnitTestSuite

javeme · 2019-07-17T11:21:23Z

src/test/java/com/baidu/hugegraph/BaseClientTest.java

+            edges.add(edge);
+        }
+        return edges;
+    }


also move to BatchUpdateElementApiTest

javeme · 2019-07-17T11:27:30Z

src/test/java/com/baidu/hugegraph/api/BatchUpdateElementApiTest.java

+        Assert.assertThrows(ServerException.class, () -> {
+            this.edgeAPI.update(req);
+        });
+    }


add test cases:

updateStrategies is empty map createIfNotExist = false edges is null edges is empty one of edge in edges is null

javeme · 2019-07-19T13:38:57Z

src/test/java/com/baidu/hugegraph/api/BatchUpdateElementApiTest.java

+    }
+
+    @Test
+    public void testEdgeEmptyUpdateStrategy() {


rename to testEdgeBatchUpdateWithInvalidArgs()

javeme · 2019-07-19T13:40:09Z

src/test/java/com/baidu/hugegraph/unit/BatchElementRequestTest.java

+    }
+
+    @Test
+    public void testVertexRequestBuildOK() {


move to line 41

javeme · 2019-07-19T13:40:30Z

src/test/java/com/baidu/hugegraph/unit/BatchElementRequestTest.java

+    }
+
+    @Test
+    public void testEdgeRequestBuildOK() {


move to line 89

javeme · 2019-07-20T06:02:44Z

src/test/java/com/baidu/hugegraph/api/BatchUpdateElementApiTest.java

+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+
+public class BatchUpdateElementApiTest extends BaseApiTest {


register BatchUpdateElementApiTest to com.baidu.hugegraph.api.ApiTestSuite

javeme · 2019-07-20T08:50:36Z

src/test/java/com/baidu/hugegraph/api/BatchUpdateElementApiTest.java

+        Assert.assertThrows(ServerException.class, () -> {
+            Whitebox.setInternalState(req, "vertices", null);
+            vertexAPI.update(req);
+        });


some tests may not return the expected exception, so please add assert on the exception message:

Assert.assertThrows(ServerException.class, () -> { ...; }, e -> { String expect = "..."; Assert.assertTrue(e.toString(), e.getMessage().contains(expect)); });

the same as other tests

javeme · 2019-07-20T08:52:50Z

src/test/java/com/baidu/hugegraph/api/BatchUpdateElementApiTest.java

+
+        Assert.assertThrows(ServerException.class, () -> {
+            Whitebox.setInternalState(req, "vertices", ImmutableList.of());
+            vertexAPI.update(req);


seems the server will not check vertices is empty.

javeme · 2019-07-20T09:04:20Z

src/test/java/com/baidu/hugegraph/api/BatchUpdateElementApiTest.java

+        Assert.assertThrows(ServerException.class, () -> {
+            Whitebox.setInternalState(req, "vertices", ImmutableList.of());
+            vertexAPI.update(req);
+        });


add cases:

vertices.size() > 500

property type error like SUM strategy with string property, or UNION strategy with string property. (add a new test method for this cases)

other exception cases

javeme · 2019-07-20T09:11:43Z

src/main/java/com/baidu/hugegraph/api/graph/structure/BatchVertexRequest.java

+        }
+
+        public BatchVertexRequest build() {
+            E.checkArgumentNotNull(req, "BatchVertexRequest cannot be null");


prefer to replace all "cannot" to "can't"

zhoney · 2019-07-22T09:10:31Z

src/main/java/com/baidu/hugegraph/api/graph/structure/BatchEdgeRequest.java

+            return this;
+        }
+
+        public Builder updatingStrategies(Map<String, UpdateStrategy> map) {


updateStrategies

refer to here
seems to distinguish between updating strategies (nouns) & update some strategies (verb)

zhoney · 2019-07-22T09:10:38Z

src/main/java/com/baidu/hugegraph/api/graph/structure/BatchEdgeRequest.java

+            return this;
+        }
+
+        public Builder updatingStrategy(String property,


zhoney · 2019-07-22T09:10:51Z

src/main/java/com/baidu/hugegraph/api/graph/structure/BatchVertexRequest.java

+            return this;
+        }
+
+        public Builder updatingStrategies(Map<String, UpdateStrategy> map) {


zhoney · 2019-07-22T09:10:58Z

src/main/java/com/baidu/hugegraph/api/graph/structure/BatchVertexRequest.java

+            return this;
+        }
+
+        public Builder updatingStrategy(String property,


zhoney · 2019-07-22T09:11:22Z

src/main/java/com/baidu/hugegraph/api/graph/structure/BatchVertexRequest.java

+                            "Parameter 'update_strategies' can't be empty");
+            E.checkArgument(req.createIfNotExist == true,
+                            "Parameter 'create_if_not_exist' " +
+                            "dose not supported false now");


does not support false now

javeme · 2019-07-23T03:18:30Z

src/test/java/com/baidu/hugegraph/api/BatchUpdateElementApiTest.java

            vertexAPI.update(req1);
        }, e -> {
-            String expect = "Property must be Number, but got String, String";
+            String expect = "Property must be Number type for strategy SUM, " +


Property type must be Number

javeme · 2019-07-23T08:02:15Z

src/test/java/com/baidu/hugegraph/api/BatchUpdateElementApiTest.java

+            vertexAPI.update(req6);
+        }, e -> {
+            String expect = "Property type must be Set or List for " +
+                            "strategy UNION, but got type Integer, Integer";


javeme · 2019-07-24T05:35:03Z

src/main/java/com/baidu/hugegraph/api/graph/EdgeAPI.java

    }

+    public List<Edge> update(BatchEdgeRequest request) {
+        RestResult result = this.client.put(this.batchPath(), null, request);


pass headers

MultivaluedHashMap<String, Object> headers = new MultivaluedHashMap<>(); headers.putSingle("Content-Encoding", BATCH_ENCODING);

javeme · 2019-07-24T05:35:18Z

src/main/java/com/baidu/hugegraph/api/graph/VertexAPI.java

    }

+    public List<Vertex> update(BatchVertexRequest request) {
+        RestResult result = this.client.put(this.batchPath(), null, request);


Linary requested changes May 23, 2019

View reviewed changes

javeme requested changes Jun 4, 2019

View reviewed changes

imbajin force-pushed the support-batch-update branch from 9c6140d to 99558b2 Compare July 10, 2019 03:06

Linary requested changes Jul 10, 2019

View reviewed changes

imbajin and others added 5 commits July 10, 2019 11:50

Support batch updating elements' property

c9d0789

Need more Unit-Tests for different update strategy.

adapt for server & add unit-test for vertex

537a5a6

clean some code

f9e86e6

Improve some code

3bcdd63

Change-Id: I2d6e6fba7527f18e1c5b29ace377639cb6f8f824

clean code &&cherry-pick pull#54

a2b555a

imbajin force-pushed the support-batch-update branch from f47a393 to a2b555a Compare July 10, 2019 06:55

javeme requested changes Jul 10, 2019

View reviewed changes

imbajin added 2 commits July 11, 2019 22:58

add edge's test

8c6ca01

clean code

85c5df9

javeme requested changes Jul 12, 2019

View reviewed changes

Extract common methods & add more test cases

0c873e4

javeme requested changes Jul 15, 2019

View reviewed changes

imbajin added 2 commits July 16, 2019 22:11

move tests to separate class

d2803ba

clean code

2b31962

javeme requested changes Jul 17, 2019

View reviewed changes

move code & add tests

6b943cc

javeme requested changes Jul 17, 2019

View reviewed changes

imbajin added 2 commits July 19, 2019 17:56

add negative tests

e2d4650

format code

6021273

javeme reviewed Jul 19, 2019

View reviewed changes

rename method

48cf8d1

javeme requested changes Jul 20, 2019

View reviewed changes

javeme reviewed Jul 20, 2019

View reviewed changes

add more negative tests

065f0b3

zhoney suggested changes Jul 22, 2019

View reviewed changes

unified exception info

0f2b1e3

javeme requested changes Jul 23, 2019

View reviewed changes

format info

5d706f1

javeme previously approved these changes Jul 23, 2019

View reviewed changes

javeme reviewed Jul 23, 2019

View reviewed changes

assert right strategy

b939a04

imbajin dismissed javeme’s stale review via b939a04 July 23, 2019 10:07

javeme requested changes Jul 24, 2019

View reviewed changes

add gzip header

7b2f16b

imbajin force-pushed the support-batch-update branch from 4dbe08b to 7b2f16b Compare July 24, 2019 06:56

Merge branch 'master' into support-batch-update

e807719

Linary approved these changes Jul 25, 2019

View reviewed changes

zhoney approved these changes Jul 25, 2019

View reviewed changes

javeme approved these changes Jul 25, 2019

View reviewed changes

javeme merged commit 1dc9e47 into hugegraph:master Jul 25, 2019

zhoney pushed a commit to zhoney/hugegraph-client that referenced this pull request Sep 19, 2019

Support batch updating elements' property (hugegraph#46)

e82821e


		public class BatchUpdateElementApiTest extends BaseApiTest {

		final int number = 5;

Support batch updating elements' property #46

Support batch updating elements' property #46

Uh oh!

Conversation

imbajin commented Apr 30, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jul 16, 2019 •

edited

Loading