Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support gremlin result attach GraphManager #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 29, 2019
Merged

Support gremlin result attach GraphManager #49

merged 3 commits into from
May 29, 2019

Conversation

Linary
Copy link
Contributor

@Linary Linary commented May 28, 2019

Change-Id: I912eace9eb3f8fc71590ca2e453b84803def445c

@Linary
Support gremlin result attach GraphManager
5d10463 
Change-Id: I912eace9eb3f8fc71590ca2e453b84803def445c
javeme
javeme requested changes May 28, 2019
View reviewed changes
@Linary Linary force-pushed the gremlin-vertex-addEdge branch 3 times, most recently from 79f3f2b to 1c5a061 Compare May 28, 2019 08:15
@hugegraph hugegraph deleted a comment from codecov bot May 28, 2019
@Linary Linary force-pushed the gremlin-vertex-addEdge branch from 1c5a061 to 207f291 Compare May 28, 2019 08:44
@codecov
Copy link

codecov bot commented May 28, 2019 •
edited
Loading

Codecov Report

Merging #49 into master will increase coverage by 0.26%.
The diff coverage is 78.26%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #49      +/-   ##
============================================
+ Coverage     74.45%   74.72%   +0.26%     
- Complexity      493      501       +8     
============================================
  Files            92       92              
  Lines          2161     2180      +19     
  Branches        129      134       +5     
============================================
+ Hits           1609     1629      +20     
+ Misses          454      451       -3     
- Partials         98      100       +2
Impacted Files Coverage Δ Complexity Δ
...va/com/baidu/hugegraph/structure/GraphElement.java 88.88% <ø> (ø) 11 <0> (ø) ⬇️
...in/java/com/baidu/hugegraph/client/RestClient.java 80% <ø> (ø) 7 <0> (ø) ⬇️
...in/java/com/baidu/hugegraph/driver/HugeClient.java 60.78% <100%> (ø) 11 <0> (ø) ⬇️
...om/baidu/hugegraph/structure/gremlin/Response.java 80% <100%> (+17.5%) 5 <1> (+2) ⬆️
...ava/com/baidu/hugegraph/driver/GremlinManager.java 92.3% <100%> (+0.64%) 3 <1> (ø) ⬇️
...java/com/baidu/hugegraph/structure/graph/Path.java 75.75% <57.14%> (-1.17%) 14 <2> (+3)
...m/baidu/hugegraph/structure/gremlin/ResultSet.java 78.26% <80%> (+10.69%) 13 <1> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70307e9...fb02511. Read the comment docs.

@Linary
fix unit tests
964f99d 
Change-Id: Icbeceea7b132795c278e4ea9c1af8e85ebc95978
@Linary Linary force-pushed the gremlin-vertex-addEdge branch from 207f291 to 964f99d Compare May 28, 2019 09:51
javeme
javeme requested changes May 28, 2019
View reviewed changes
@Linary
tiny improve
fb02511 
Change-Id: Id82434ce3f148ac2f44db9a29ed051c9f837a04e
@Linary Linary force-pushed the gremlin-vertex-addEdge branch from 5047972 to fb02511 Compare May 29, 2019 02:26
@zhoney zhoney merged commit 2b7ace6 into master May 29, 2019
@zhoney zhoney deleted the gremlin-vertex-addEdge branch May 29, 2019 12:10
@Linary Linary mentioned this pull request May 30, 2019
Closed
imbajin pushed a commit to imbaGeek/hugegraph-client that referenced this pull request Jul 10, 2019
@Linary @imbajin
Support gremlin result attach GraphManager (hugegraph#49)
ef86952 
Change-Id: I912eace9eb3f8fc71590ca2e453b84803def445c
imbajin pushed a commit to imbaGeek/hugegraph-client that referenced this pull request Jul 10, 2019
@Linary @imbajin
Support gremlin result attach GraphManager (hugegraph#49)
5db579b 
Change-Id: I912eace9eb3f8fc71590ca2e453b84803def445c
zhoney pushed a commit to zhoney/hugegraph-client that referenced this pull request Sep 19, 2019
@Linary @zhoney
Support gremlin result attach GraphManager (hugegraph#49)
4833076 
Change-Id: I912eace9eb3f8fc71590ca2e453b84803def445c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javeme javeme javeme approved these changes

+1 more reviewer

@zhoney zhoney zhoney approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Linary @javeme @zhoney