adapt to update_props(aggregate) #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javeme
requested changes
Sep 24, 2019
| @JsonProperty("aggregate_type") | ||
| private AggregateType aggregateType; | ||
|
|
||
| public static final String TOP_N = "~topN"; |
| @JsonProperty("cardinality") | ||
| private Cardinality cardinality; | ||
| @JsonProperty("aggregate_type") | ||
| private AggregateType aggregateType; |
There was a problem hiding this comment.
keep compatible with v0.9:
- read schema from v0.9
- write schema to v0.9 (optional)
implemented: #691 Change-Id: I861927cfa48407759785534b4045a55e73ef7a00
javeme
requested changes
Oct 7, 2019
|
|
||
| public PropertyKey create(PropertyKey propertyKey) { | ||
| RestResult result = this.client.post(this.path(), propertyKey); | ||
| Object pk; |
| OLD(4, "old"); | ||
|
|
||
| private byte code = 0; | ||
| private String name = null; |
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
===========================================
+ Coverage 75.57% 75.67% +0.1%
- Complexity 519 545 +26
===========================================
Files 94 95 +1
Lines 2321 2376 +55
Branches 145 147 +2
===========================================
+ Hits 1754 1798 +44
- Misses 464 469 +5
- Partials 103 109 +6
Continue to review full report at Codecov.
|
Change-Id: I18a9feafcd3500df17a8f1111b6abfda6a1c76f4
javeme
requested changes
Oct 12, 2019
| .asText().valueSingle() | ||
| .build(); | ||
| PropertyKey.PropertyKeyV46 pk = propertyKey.switchV46(); | ||
| Assert.assertEquals("nameV46", pk.name()); |
There was a problem hiding this comment.
add more assert for other fields
| Assert.assertTrue(propertyKey.aggregateType().isNumber()); | ||
|
|
||
| propertyKey = schema().propertyKey("nameV46") | ||
| .asText().valueSingle() |
| String apiVersion = this.apiVersion == null ? | ||
| null : this.apiVersion.get(); | ||
| if (apiVersion != null && !VersionUtil.gte(apiVersion, minVersion)) { | ||
| if (this.ltApiVersion(minVersion)) { |
javeme
approved these changes
Oct 14, 2019
Linary
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented: #691
Change-Id: I861927cfa48407759785534b4045a55e73ef7a00