Add metrics api and manager #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
============================================
+ Coverage 76.74% 77.16% +0.42%
- Complexity 587 604 +17
============================================
Files 99 102 +3
Lines 2541 2593 +52
Branches 159 163 +4
============================================
+ Hits 1950 2001 +51
- Misses 471 472 +1
Partials 120 120
Continue to review full report at Codecov.
|
javeme
requested changes
Jan 22, 2020
| @SuppressWarnings("unchecked") | ||
| public Map<String, Map<String, Object>> backend() { | ||
| RestResult result = this.client.get(this.path(), "backend"); | ||
| return result.readObject(Map.class); |
There was a problem hiding this comment.
check value is map or call readObject(Type)
| public Map<String, Map<String, Object>> backend() { | ||
| RestResult result = this.client.get(this.path(), "backend"); | ||
| return result.readObject(Map.class); | ||
| } |
There was a problem hiding this comment.
also adapt for metrics/system and metrics/
|
rebase please |
Change-Id: If449304910f4b448d9a13ba8c23954503c130732
Change-Id: Id59ec6e57afdaee27a251d454a7563031b68c052
Change-Id: I0847518c7797afe5533ab6ab462a76ec6c88f1e3
javeme
approved these changes
Feb 16, 2020
zhoney
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.