Sunset Python 3.8 & get rid of explicit typing exports where possible#12524
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
tolgacangoz
reviewed
Oct 22, 2025
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
DN6
reviewed
Feb 10, 2026
DN6
reviewed
Feb 13, 2026
| return tensor | ||
|
|
||
|
|
||
| class AllGatherAnythingFunction(torch.autograd.Function): |
Member
Author
There was a problem hiding this comment.
It's there in main:
DN6
reviewed
Feb 13, 2026
yiyixuxu
reviewed
Feb 14, 2026
| self._input_fields: Dict[str, Union[str, Tuple[str, str]]] = None | ||
| self._enabled = enabled | ||
| self._input_fields: dict[str, str | tuple[str, str]] = None | ||
| self._enabled = True |
Collaborator
There was a problem hiding this comment.
Suggested change
| self._enabled = True | |
| self._enabled = enabled |
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Python 3.8 has grown quite old, and I don't think any HF library has it as a minimum requirement.
Sunsetting this version also allows us to take advantage of the implicit typing support (
List[float]->list[float], for example).The main changes to review are in:
src/diffusers/pipelines/pipeline_utils.pysrc/diffusers/utils/typing_utils.py